From: Eric Blake <eblake@redhat.com>
To: Maxim Levitsky <mlevitsk@redhat.com>, qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
qemu-block@nongnu.org, "Markus Armbruster" <armbru@redhat.com>,
"Max Reitz" <mreitz@redhat.com>, "John Snow" <jsnow@redhat.com>
Subject: Re: [PATCH v2 00/14] LUKS: encryption slot management using amend interface
Date: Thu, 12 Mar 2020 06:56:27 -0500 [thread overview]
Message-ID: <bd526fff-5719-c056-e1cc-722c4e49c82b@redhat.com> (raw)
In-Reply-To: <20200308151903.25941-1-mlevitsk@redhat.com>
On 3/8/20 10:18 AM, Maxim Levitsky wrote:
> Hi!
> Here is the updated series of my patches, incorporating all the feedback I received.
>
> Patches are strictly divided by topic to 3 groups, and each group depends on former groups.
>
> * Patches 1,2 implement qcrypto generic amend interface, including definition
> of structs used in crypto.json and implement this in luks crypto driver
> Nothing is exposed to the user at this stage
>
> * Patches 3-9 use the code from patches 1,2 to implement qemu-img amend based encryption slot management
> for luks and for qcow2, and add a bunch of iotests to cover that.
>
> * Patches 10-13 add x-blockdev-amend (I'll drop the -x prefix if you like), and wire it
> to luks and qcow2 driver to implement qmp based encryption slot management also using
> the code from patches 1,2, and also add a bunch of iotests to cover this.
> tests/qemu-iotests/284.out | 6 +-
> tests/qemu-iotests/300 | 207 ++++++++++++++++
Any reason why you skipped straight to test 300, rather than using an
available slot like 290? (Admittedly, our process for reserving slots
is not very high-tech: manually scan the list for what other patches out
there have claimed a slot, and be prepared to renumber when rebasing)
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2020-03-12 11:57 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-08 15:18 [PATCH v2 00/14] LUKS: encryption slot management using amend interface Maxim Levitsky
2020-03-08 15:18 ` [PATCH v2 01/14] qcrypto/core: add generic infrastructure for crypto options amendment Maxim Levitsky
2020-03-08 15:18 ` [PATCH v2 02/14] qcrypto/luks: implement encryption key management Maxim Levitsky
2020-03-10 10:58 ` Max Reitz
2020-03-10 11:05 ` Maxim Levitsky
2020-03-10 11:59 ` Kevin Wolf
2020-03-10 12:02 ` Maxim Levitsky
2020-03-11 12:55 ` Maxim Levitsky
2020-04-28 13:16 ` Daniel P. Berrangé
2020-05-03 8:55 ` Maxim Levitsky
2020-05-04 9:18 ` Daniel P. Berrangé
2020-03-08 15:18 ` [PATCH v2 03/14] block/amend: add 'force' option Maxim Levitsky
2020-03-08 15:18 ` [PATCH v2 04/14] block/amend: separate amend and create options for qemu-img Maxim Levitsky
2020-04-28 15:03 ` Daniel P. Berrangé
2020-04-28 15:49 ` Daniel P. Berrangé
2020-03-08 15:18 ` [PATCH v2 05/14] block/amend: refactor qcow2 amend options Maxim Levitsky
2020-04-28 15:51 ` Daniel P. Berrangé
2020-03-08 15:18 ` [PATCH v2 06/14] block/crypto: rename two functions Maxim Levitsky
2020-03-08 15:18 ` [PATCH v2 07/14] block/crypto: implement the encryption key management Maxim Levitsky
2020-04-28 16:15 ` Daniel P. Berrangé
2020-03-08 15:18 ` [PATCH v2 08/14] block/qcow2: extend qemu-img amend interface with crypto options Maxim Levitsky
2020-04-28 16:17 ` Daniel P. Berrangé
2020-03-08 15:18 ` [PATCH v2 09/14] iotests: filter few more luks specific create options Maxim Levitsky
2020-04-28 16:19 ` Daniel P. Berrangé
2020-03-08 15:18 ` [PATCH v2 10/14] iotests: qemu-img tests for luks key management Maxim Levitsky
2020-04-28 16:21 ` Daniel P. Berrangé
2020-03-08 15:19 ` [PATCH v2 11/14] block/core: add generic infrastructure for x-blockdev-amend qmp command Maxim Levitsky
2020-04-28 16:25 ` Daniel P. Berrangé
2020-03-08 15:19 ` [PATCH v2 12/14] block/crypto: implement blockdev-amend Maxim Levitsky
2020-03-08 15:19 ` [PATCH v2 13/14] block/qcow2: " Maxim Levitsky
2020-03-08 15:19 ` [PATCH v2 14/14] iotests: add tests for blockdev-amend Maxim Levitsky
2020-04-28 16:23 ` Daniel P. Berrangé
2020-03-12 11:56 ` Eric Blake [this message]
2020-03-12 14:33 ` [PATCH v2 00/14] LUKS: encryption slot management using amend interface Maxim Levitsky
-- strict thread matches above, loose matches on Subject: below --
2020-01-30 17:29 Maxim Levitsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd526fff-5719-c056-e1cc-722c4e49c82b@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mlevitsk@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).