From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34989) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eWGHw-0000O1-OA for qemu-devel@nongnu.org; Tue, 02 Jan 2018 01:43:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eWGHt-0008MX-L2 for qemu-devel@nongnu.org; Tue, 02 Jan 2018 01:43:04 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:57580) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eWGHt-0008Lk-Bt for qemu-devel@nongnu.org; Tue, 02 Jan 2018 01:43:01 -0500 Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id w026cUHM092183 for ; Tue, 2 Jan 2018 01:42:59 -0500 Received: from e37.co.us.ibm.com (e37.co.us.ibm.com [32.97.110.158]) by mx0a-001b2d01.pphosted.com with ESMTP id 2f7rrn16kj-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 02 Jan 2018 01:42:58 -0500 Received: from localhost by e37.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 1 Jan 2018 23:42:57 -0700 References: <1511273358-21789-1-git-send-email-s1seetee@linux.vnet.ibm.com> <20171212164114.GF2409@work-vm> <225a4478-dc5e-a067-f207-e8a183afa0d9@linux.vnet.ibm.com> <9b719ebe-8b38-708c-45a7-d377a583f899@redhat.com> <5e07b5ea-e8b0-521a-b1af-31017fc52578@redhat.com> <87shc3rz5d.fsf@dusky.pond.sub.org> From: seeteena Date: Tue, 2 Jan 2018 12:12:49 +0530 MIME-Version: 1.0 In-Reply-To: <87shc3rz5d.fsf@dusky.pond.sub.org> Content-Language: en-US Message-Id: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v1] hmp: 'info snapshots' not showing the id List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , Eric Blake Cc: Max Reitz , "Dr. David Alan Gilbert" , lma@suse.com, qemu-devel@nongnu.org On 12/22/2017 01:07 PM, Markus Armbruster wrote: > Eric Blake writes: > >> On 12/19/2017 08:20 AM, Max Reitz wrote: >> >>> So there are three things: >>> >>> (1) We probably should not allow snapshot names that could be IDs. >>> Easiest way to solve this: Names have to start with a non-digit. >> Yes, that would be a nice change. It is not strictly backwards >> compatible (so we'd still have to cope with images that didn't follow >> the rule, whether created by older qemu or by non-qemu implementations >> of qcow2), but would alleviate a lot of confusion. > I recommend to restrict ID strings to letters, digits, '-', '.', '_', > starting with a letter. Use id_wellformed() to check. char *id_generate(IdSubSystems id) autogenates ID in the format eg- "#block146" with starting with '#' always. restricting ID strings to use id_wellformed() means we need to force ID to start with letter. #define ID_SPECIAL_CHAR '#' needs to change to (some letter) #define ID_SPECIAL_CHAR 'A' > > If backward compatibility is an issue, deprecate offending IDs (with a > suitable warning), and kill them off after the customary grace period. > > IDs embedded in image files and such you may have to keep working > somehow indefinitely. >