Re: [PATCH-for-10.0 3/3] hw/sd/sdcard: Remove support for spec v1.10

["Philippe Mathieu-Daudé" <philmd@linaro.org>]

On 1/9/25 09:41, Philippe Mathieu-Daudé wrote:
> On 1/9/25 09:29, Philippe Mathieu-Daudé wrote:
>> Kind ping :)
>>
>> On 27/6/24 09:10, Philippe Mathieu-Daudé wrote:
>>> Support for spec v1.10 was deprecated in QEMU v9.1.
>>>
>>> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>>> ---
>>>   docs/about/deprecated.rst       |  6 ------
>>>   docs/about/removed-features.rst |  5 +++++
>>>   include/hw/sd/sd.h              |  1 -
>>>   hw/sd/sd.c                      | 12 ++----------
>>>   4 files changed, 7 insertions(+), 17 deletions(-)
>>>
>>> diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst
>>> index 02cdef14aa..ff3da68208 100644
>>> --- a/docs/about/deprecated.rst
>>> +++ b/docs/about/deprecated.rst
>>> @@ -362,12 +362,6 @@ recommending to switch to their stable 
>>> counterparts:
>>>   - "Zve64f" should be replaced with "zve64f"
>>>   - "Zve64d" should be replaced with "zve64d"
>>> -``-device sd-card,spec_version=1`` (since 9.1)
>>> -^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>>> -
>>> -SD physical layer specification v2.00 supersedes the v1.10 one.
>>> -v2.00 is the default since QEMU 3.0.0.
>>> -
>>>   Block device options
>>>   ''''''''''''''''''''
>>> diff --git a/docs/about/removed-features.rst b/docs/about/removed- 
>>> features.rst
>>> index fc7b28e637..dfe04b0555 100644
>>> --- a/docs/about/removed-features.rst
>>> +++ b/docs/about/removed-features.rst
>>> @@ -1056,6 +1056,11 @@ by using ``-machine graphics=off``.
>>>   The 'pvrdma' device and the whole RDMA subsystem have been removed.
>>> +``-device sd-card,spec_version=1`` (since 10.0)
> 
> Updated to "10.2".

As discussed with Pierrick during online review:

Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>