From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58253) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDJc3-0001Mr-16 for qemu-devel@nongnu.org; Wed, 15 Jun 2016 18:48:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bDJc1-0006Mo-5E for qemu-devel@nongnu.org; Wed, 15 Jun 2016 18:48:42 -0400 Sender: Paolo Bonzini References: <1466016055-31351-1-git-send-email-clord@redhat.com> <1466016055-31351-2-git-send-email-clord@redhat.com> From: Paolo Bonzini Message-ID: Date: Thu, 16 Jun 2016 00:48:31 +0200 MIME-Version: 1.0 In-Reply-To: <1466016055-31351-2-git-send-email-clord@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/2] blockdev: Add dynamic generation of module_block.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Colin Lord , qemu-devel@nongnu.org Cc: kwolf@redhat.com, markmb@redhat.com, qemu-block@nongnu.org, mreitz@redhat.com On 15/06/2016 20:40, Colin Lord wrote: > +def add_module(fhader, library, format_name, protocol_name, fhader looks like a typo. Paolo > + probe, probe_device): > + lines = [] > + lines.append('.library_name = "' + library + '",') > + if format_name != "": > + lines.append('.format_name = "' + format_name + '",') > + if protocol_name != "": > + lines.append('.protocol_name = "' + protocol_name + '",') > + if probe: > + lines.append('.has_probe = true,') > + if probe_device: > + lines.append('.has_probe_device = true,') > + > + text = '\n\t'.join(lines) > + fheader.write('\n\t{\n\t' + text + '\n\t},')