From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Cc: "Fam Zheng" <fam@euphon.net>,
"Yoshinori Sato" <ysato@users.sourceforge.jp>,
qemu-trivial@nongnu.org, "Magnus Damm" <magnus.damm@gmail.com>,
"Michael Tokarev" <mjt@tls.msk.ru>,
"Laurent Vivier" <laurent@vivier.eu>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH v4 1/7] MAINTAINERS: Cover 'hw/sh4/sh_intc.h' with the R2D machine
Date: Tue, 16 Jun 2020 17:56:27 +0200 [thread overview]
Message-ID: <bd8d3086-8fe7-958f-a54e-95d69f399627@redhat.com> (raw)
In-Reply-To: <94575412-81ae-25e1-b9ad-b12317da815b@amsat.org>
On 16/06/2020 16.49, Philippe Mathieu-Daudé wrote:
> On 6/16/20 3:34 PM, Thomas Huth wrote:
>> On 11/06/2020 13.43, Philippe Mathieu-Daudé wrote:
>>> Commit 81527b94ad added hw/intc/sh_intc.c, complete by
>>> adding its corresponding header.
>>>
>>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>> ---
>>> MAINTAINERS | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>> index 13711aafe8..87ceca7ff1 100644
>>> --- a/MAINTAINERS
>>> +++ b/MAINTAINERS
>>> @@ -1257,6 +1257,7 @@ S: Maintained
>>> F: hw/sh4/r2d.c
>>> F: hw/intc/sh_intc.c
>>> F: hw/timer/sh_timer.c
>>> +F: include/hw/sh4/sh_intc.h
>>>
>>> Shix
>>> M: Yoshinori Sato <ysato@users.sourceforge.jp>
>>
>> Hmm, sh_intc.h is used by sh7750_init() in sh7750.c ... and that
>> function is used by both, r2d and shix machines ... so should that maybe
>> rather be part of both machines or a generic entry?
>
> I'll add it to both machines. The maintainers can reorder
> the sections later.
>
> Thanks for the review!
Ok, with that change:
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2020-06-16 15:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 11:43 [PATCH v4 0/7] sh4: Add 'Renesas peripherals' entry in MAINTAINERS + trivial fixes Philippe Mathieu-Daudé
2020-06-11 11:43 ` [PATCH v4 1/7] MAINTAINERS: Cover 'hw/sh4/sh_intc.h' with the R2D machine Philippe Mathieu-Daudé
2020-06-16 13:34 ` Thomas Huth
2020-06-16 14:49 ` Philippe Mathieu-Daudé
2020-06-16 15:56 ` Thomas Huth [this message]
2020-06-11 11:43 ` [PATCH v4 2/7] MAINTAINERS: Add an entry for common Renesas peripherals Philippe Mathieu-Daudé
2020-06-20 17:41 ` Richard Henderson
2020-06-11 11:43 ` [PATCH v4 3/7] hw/sh4: Use MemoryRegion typedef Philippe Mathieu-Daudé
2020-06-11 11:43 ` [PATCH v4 4/7] hw/sh4: Extract timer definitions to 'hw/timer/tmu012.h' Philippe Mathieu-Daudé
2020-06-11 11:43 ` [PATCH v4 5/7] hw/timer/sh_timer: Remove unused 'qemu/timer.h' include Philippe Mathieu-Daudé
2020-06-11 11:43 ` [PATCH v4 6/7] tests/acceptance: Add boot tests for sh4 QEMU advent calendar image Philippe Mathieu-Daudé
2020-06-11 11:43 ` [PATCH v4 7/7] .travis.yml: Test SH4 " Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd8d3086-8fe7-958f-a54e-95d69f399627@redhat.com \
--to=thuth@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=f4bug@amsat.org \
--cc=fam@euphon.net \
--cc=laurent@vivier.eu \
--cc=magnus.damm@gmail.com \
--cc=mjt@tls.msk.ru \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).