From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] error: Drop bogus "use error_setg() instead" admonitions
Date: Fri, 19 Oct 2018 08:13:00 -0500 [thread overview]
Message-ID: <bd958bd4-5f04-b65e-6c9d-e66e6680f7d9@redhat.com> (raw)
In-Reply-To: <20181019123923.26649-1-armbru@redhat.com>
On 10/19/18 7:39 AM, Markus Armbruster wrote:
> Commit 97f40301f1d "error: Functions to report warnings and
> informational messages" copied the "use error_setg() instead"
> admonition from the error reporting functions to new functions even
> though it doesn't actually apply there. Drop it. Also drop it from
> vreport(), where it doesn't apply anymore.
>
> Reported-by: Kevin Wolf <kwolf@redhat.com>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> util/qemu-error.c | 5 -----
> 1 file changed, 5 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
prev parent reply other threads:[~2018-10-19 13:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-19 12:39 [Qemu-devel] [PATCH] error: Drop bogus "use error_setg() instead" admonitions Markus Armbruster
2018-10-19 13:13 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd958bd4-5f04-b65e-6c9d-e66e6680f7d9@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).