From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 22B22C87FD2 for ; Fri, 1 Aug 2025 01:44:04 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uheoD-0007Rb-Qf; Thu, 31 Jul 2025 21:43:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uhem1-0004F9-Hz for qemu-devel@nongnu.org; Thu, 31 Jul 2025 21:41:29 -0400 Received: from mail-pf1-x434.google.com ([2607:f8b0:4864:20::434]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uhelz-0001RG-VF for qemu-devel@nongnu.org; Thu, 31 Jul 2025 21:41:29 -0400 Received: by mail-pf1-x434.google.com with SMTP id d2e1a72fcca58-76bdce2ee10so236736b3a.2 for ; Thu, 31 Jul 2025 18:41:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1754012486; x=1754617286; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xVZYVwgSk9RzCvXFw7opvZRkc1d6fUqSbKAWeRUy5c8=; b=MqO8TQYOG1nLUPbBshXpviwb40fm4w7jsBT4VEHhuIsb9vbgNFCah1u/7DwWW8NFiu 9uhoplZMOMHTsTwcfn9rPa7JqY30FbKeJshNQFfUygJNVyHh5D868DSYv9LS5ii8LFk0 m3Gu4fnXNSkquKotnriUH8iqbYilzDusuP6XwgD0T5c6ENQ/7KzWXTS6H9vrqH3F8lV6 iekhHjNxawSv6jAVHUcO22TBU5DEMWAPk8lpW8udvHs+jBEI/3o+NK1wvre6L1GOyGVE yM3EIOS4Up4FoWdSFKVY6VFojjQMYfwouFXKoGJGpDCvzRLVv6v8/yjq4LZpxNkKTG14 seWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754012486; x=1754617286; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xVZYVwgSk9RzCvXFw7opvZRkc1d6fUqSbKAWeRUy5c8=; b=L56OAFeJjsCgotaCYFgtX/3WfsqlMS4+7dkrN7WL51BvrwYpvMIKPPEq9qDaXl4X3+ SYoewcv1Q+NcFym9Ra4OlD5l8pidhJpgPuJru2XfjB3aG3LfNhaRvpCIA7rK1NTMdUPr q6gSsCUMpwNLwh8wc4Xifqgo5s3w+90uXmlOQLI0u+5tEemnly00ndPRsyPtEwjn34tI URojJf+mgEeTdbePfdDk2mRyCWGvYyWUw7BK5IAQ7D+IIZGkDLHO4lR8hX2Vy99wacb8 82SSd2UTtZPQCVY7PiSArpo1GHzbfpO7v+7DrN6tJ5Dntb4FNRpW0nAnylFqfWwX5zht bpQg== X-Forwarded-Encrypted: i=1; AJvYcCXWmGxFf3hSBs+f1qiR2rU1L7iXMD6SI7/Furj/9+7VOTzI14VhutWlgm98LCWQiCdscZToR74VbNtH@nongnu.org X-Gm-Message-State: AOJu0YxJt2tn4jAQ5DVlV0EOUuQuUoP6LaCeaSBeegiU2EXgKsdX6i4t rXJ5bMdvQ2JSahtJCzwUDeNf+OuN/DBEV/WwEo5Wcrf1OW5AwYkR8WYeIWwl36wTWEI= X-Gm-Gg: ASbGncsCZP20BwcV0piZHkZ95equtEHD1PCGx4ucMNvHiZRxS60aH9EMc76nnu/10Bg /ZIJTazZyIwEMbys69TLqYDPhXVTihia42GsPvJ1X/cN5+IH0g76BfYyC4rh1qNLU8w/UMU0oND thImsJa74hgiH04DoVtgU0fYQh8YZBW1uAebDKATBNwh3E4wDfzasXy5sTcAPSpyfkVm0cVW+gp 6CPbiO0y0KFF1WVm7baN1n0mw1x/8U6yu02nNI+ygKoF3K2hPs5/IA7b7PzD7RxvN97XEg+GJdO hRPzmwSqDXvQmHZsqDi8G5IUNj2/skQ+Mra5D3huoYbm9S3ZI5N/mdTpLPf7uXc/R/pCaTHTASs /HgE7O7ZEAbOSy33cQWqw8DO4FvkJB3fqXCYIrwaO1v7+NQ== X-Google-Smtp-Source: AGHT+IHLo267rMItO8mP8JmmirjpoTmHCLB5e5JnpvAJ0AWs3ECNudY9DF96HmM0RedEchXrbCVqSg== X-Received: by 2002:aa7:88c9:0:b0:739:50c0:b3fe with SMTP id d2e1a72fcca58-76ab14172b3mr16031366b3a.8.1754012486055; Thu, 31 Jul 2025 18:41:26 -0700 (PDT) Received: from [192.168.1.87] ([38.41.223.211]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-76bcce89132sm2703235b3a.29.2025.07.31.18.41.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 31 Jul 2025 18:41:25 -0700 (PDT) Message-ID: Date: Thu, 31 Jul 2025 18:41:24 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 02/10] semihosting/guestfd: compile once for system/user Content-Language: en-US To: Richard Henderson , qemu-devel@nongnu.org Cc: Daniel Henrique Barboza , Peter Maydell , qemu-arm@nongnu.org, =?UTF-8?Q?Alex_Benn=C3=A9e?= , Weiwei Li , philmd@linaro.org, Liu Zhiwei , Palmer Dabbelt , qemu-riscv@nongnu.org, Alistair Francis References: <20250730220621.1142496-1-pierrick.bouvier@linaro.org> <20250730220621.1142496-3-pierrick.bouvier@linaro.org> From: Pierrick Bouvier In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::434; envelope-from=pierrick.bouvier@linaro.org; helo=mail-pf1-x434.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 7/31/25 4:15 PM, Richard Henderson wrote: > On 7/31/25 08:06, Pierrick Bouvier wrote: >> diff --git a/semihosting/arm-compat-semi.c b/semihosting/arm-compat-semi.c >> index 40dc778529d..33614108094 100644 >> --- a/semihosting/arm-compat-semi.c >> +++ b/semihosting/arm-compat-semi.c >> @@ -101,6 +101,13 @@ static int gdb_open_modeflags[12] = { >> GDB_O_RDWR | GDB_O_CREAT | GDB_O_APPEND, >> }; >> >> +/* >> + * For ARM semihosting, we have a separate structure for routing >> + * data for the console which is outside the guest fd address space. >> + */ >> +GuestFD console_in_gf; >> +GuestFD console_out_gf; > > These can now be static. > Yes, I forgot to reapply that from my initial series when cleaning it up. Thanks. > Otherwise, > Reviewed-by: Richard Henderson > > > r~