From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3F09BC2D0CD for ; Thu, 15 May 2025 15:46:55 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uFakQ-0002RU-Om; Thu, 15 May 2025 11:43:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uFakO-00025Y-2m; Thu, 15 May 2025 11:43:48 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uFakJ-00068Z-JL; Thu, 15 May 2025 11:43:47 -0400 Received: from pps.filterd (m0353729.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 54FCg4vM004704; Thu, 15 May 2025 15:43:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:reply-to:subject:to; s=pp1; bh=WAnX61TDjbgPwI86kKiPqpTqgeyuNigE8634PNDVx58=; b=XfK1eehPcuq3 NvZV6o8AF1gPTq39rs6BtBYMkOWPKWgi7iS7s4Grz10LbWVI3970saIw2BBVqz+l 4hAT1VGcHCw0WdUOvwq7RS59z7FpxUyY5uvRpIGyDHrZJyubs4uJrK7fP9u2QCaX 7KViUhbuwlFwTBs1qOKpM/bsCiw3FJtgT7VmD60hBtWkZmB1mLdT4k3ZIzMaJGOF 0RffddyQdxEU27iFSRefZ4B2Hi6rvg8dRVY9Gi85FNoBLYlsBf12u2LnDs9WFTrs kRhEZN0Vnrc4LAutcuymiawrN2G3c0Px98X3eJAVqxQKYVVTHlrafNmRW1qefFNo 7L0AJDMbMw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 46navu2vnh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 15 May 2025 15:43:41 +0000 (GMT) Received: from m0353729.ppops.net (m0353729.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 54FFV0ZI021368; Thu, 15 May 2025 15:43:40 GMT Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 46navu2vnb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 15 May 2025 15:43:40 +0000 (GMT) Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 54FEKa9x015498; Thu, 15 May 2025 15:43:39 GMT Received: from smtprelay03.dal12v.mail.ibm.com ([172.16.1.5]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 46mbfq307g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 15 May 2025 15:43:39 +0000 Received: from smtpav06.dal12v.mail.ibm.com (smtpav06.dal12v.mail.ibm.com [10.241.53.105]) by smtprelay03.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 54FFhcwq28770946 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 15 May 2025 15:43:38 GMT Received: from smtpav06.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A040E58055; Thu, 15 May 2025 15:43:38 +0000 (GMT) Received: from smtpav06.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4BBB758043; Thu, 15 May 2025 15:43:38 +0000 (GMT) Received: from mambor8.rchland.ibm.com (unknown [9.10.239.198]) by smtpav06.dal12v.mail.ibm.com (Postfix) with ESMTP; Thu, 15 May 2025 15:43:38 +0000 (GMT) Message-ID: Subject: Re: [PATCH 11/50] ppc/xive2: Do not present group interrupt on OS-push if precluded by CPPR From: Miles Glenn To: Nicholas Piggin , qemu-ppc@nongnu.org Cc: qemu-devel@nongnu.org, =?ISO-8859-1?Q?Fr=E9d=E9ric?= Barrat , Michael Kowal , Caleb Schlossin Date: Thu, 15 May 2025 10:43:37 -0500 In-Reply-To: <20250512031100.439842-12-npiggin@gmail.com> References: <20250512031100.439842-1-npiggin@gmail.com> <20250512031100.439842-12-npiggin@gmail.com> Organization: IBM Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-27.el8_10) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: BESIkaKwTdowJ_2EgXgeEe2Ds1Zvqlcg X-Authority-Analysis: v=2.4 cv=XK4wSRhE c=1 sm=1 tr=0 ts=68260bad cx=c_pps a=bLidbwmWQ0KltjZqbj+ezA==:117 a=bLidbwmWQ0KltjZqbj+ezA==:17 a=IkcTkHD0fZMA:10 a=dt9VzEwgFbYA:10 a=VnNF1IyMAAAA:8 a=pGLkceISAAAA:8 a=6PrcOua1sW-wYeWJZ4UA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-GUID: 8r8J04x2Q9bodXukhV0nyad0PY5JV_jT X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTE1MDE1NSBTYWx0ZWRfXw6TZcryxSb7F 5hvBG0kUlnToiWnYQK7b8hoT6OY3upfA+3BZ3J+FwricqLch2YVbBjUhUsvdf5PbzYeGmja3V+f MIFM6VZxo5LsSm35SO1g5fy2rOCtlrHy9XlrZExAkpzuZpahbFn4ttDS1IQcBqrSQPTV0TxpiAK 00DDmUJXlqixBwO8j3k3/mE97LnCfyILNQmpfO1d/541lq2rrvJtBSrUcghHVwx/GPCXvagK37u twxjW01v2L4hNCrx3+npKkyaks/6rJsTjShdCJvxRum34uZ+V9KeIo1VOUMDpbDPSJIVYCaMLhe 1b0uru3z/lGFe/LJ9X9otzwBMT0StL7mU6SyNIOwfNOmfYJyI1SNJCFOyFFeMwrEycIjLKCorRj 3WM18HFYqcSPV5RURbrh0BTRkDXh/ntECANp8LNwVc7iylqnJgW+cNDtq4DL7Nj1cp4sPhwd X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-15_06,2025-05-15_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 phishscore=0 mlxscore=0 bulkscore=0 mlxlogscore=690 clxscore=1015 lowpriorityscore=0 priorityscore=1501 suspectscore=0 impostorscore=0 adultscore=0 malwarescore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505070000 definitions=main-2505150155 Received-SPF: pass client-ip=148.163.156.1; envelope-from=milesg@linux.ibm.com; helo=mx0a-001b2d01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: milesg@linux.ibm.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Reviewed-by: Glenn Miles On Mon, 2025-05-12 at 13:10 +1000, Nicholas Piggin wrote: > Group interrupts should not be taken from the backlog and presented > if they are precluded by CPPR. > > Fixes: 855434b3b8 ("ppc/xive2: Process group backlog when pushing an OS context") > Signed-off-by: Nicholas Piggin > --- > hw/intc/xive2.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/hw/intc/xive2.c b/hw/intc/xive2.c > index 1971c05fa1..8ede95b671 100644 > --- a/hw/intc/xive2.c > +++ b/hw/intc/xive2.c > @@ -845,7 +845,9 @@ static void xive2_tctx_need_resend(Xive2Router *xrtr, XiveTCTX *tctx, > group_prio = xive2_presenter_backlog_scan(xptr, nvp_blk, nvp_idx, > first_group, &group_level); > regs[TM_LSMFB] = group_prio; > - if (regs[TM_LGS] && group_prio < backlog_prio) { > + if (regs[TM_LGS] && group_prio < backlog_prio && > + group_prio < regs[TM_CPPR]) { > + > /* VP can take a group interrupt */ > xive2_presenter_backlog_decr(xptr, nvp_blk, nvp_idx, > group_prio, group_level);