qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Cédric Le Goater" <clg@redhat.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Joel Stanley" <joel@jms.id.au>,
	"Andrew Jeffery" <andrew@codeconstruct.com.au>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: Re: [PATCH v2] aspeed: Deprecate the tacoma-bmc machine
Date: Fri, 30 Aug 2024 10:09:25 +0200	[thread overview]
Message-ID: <bdb443f9-376e-4d4e-8c06-9ba0c5482c5e@redhat.com> (raw)
In-Reply-To: <014b83a8-d733-442b-ba33-a24c35e46f3f@roeck-us.net>

Hello,


>>> I solved the problem by adding support for IBM Bonnell (which instantiates
>>> the TPM chip through its devicetree file, similar to tacoma-bmc) to my local
>>> copy of qemu. 
>>
>> Hmm, did you copy the rainier-bmc machine definition ?
>>
> For aspeed_machine_bonnell_class_init(), pretty much yes, since I don't know
> the actual hardware. For I2C initialization I used the devicetree file.
> You can find the patch in the master-local or v9.1.0-local branches
> of my qemu clone at https://github.com/groeck/qemu if you are interested.

Oh nice ! Let's merge the IBM Bonnell machine. We can ask IBM to help fixing
the definitions (strapping). Enabling the PCA9554 is good to have too.

Why are you keeping the tmp105 changes ? LGTM. Same for the new tmp models,
they could be upstreamed.


Thanks,

C.



  reply	other threads:[~2024-08-30  8:09 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-25  7:08 [PATCH v2] aspeed: Deprecate the tacoma-bmc machine Cédric Le Goater
2024-06-25  7:12 ` Philippe Mathieu-Daudé
2024-07-02  5:56 ` Cédric Le Goater
2024-08-08 22:05 ` Guenter Roeck
2024-08-26  9:58   ` Cédric Le Goater
2024-08-26 18:50     ` Guenter Roeck
2024-08-28 12:35       ` Cédric Le Goater
2024-08-28 15:12         ` Guenter Roeck
2024-08-30  8:09           ` Cédric Le Goater [this message]
2024-08-30 20:11             ` Guenter Roeck
2024-09-09 11:20               ` Joel Stanley
2024-09-09 15:10                 ` Guenter Roeck
2024-09-11 17:33                   ` Cédric Le Goater
2024-09-11 18:18                     ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bdb443f9-376e-4d4e-8c06-9ba0c5482c5e@redhat.com \
    --to=clg@redhat.com \
    --cc=andrew@codeconstruct.com.au \
    --cc=joel@jms.id.au \
    --cc=linux@roeck-us.net \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).