From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, kvm@vger.kernel.org, eesposit@redhat.com
Subject: Re: [PATCH] kvm: Don't assume accel_ioctl_end() preserves @errno
Date: Tue, 25 Nov 2025 11:33:43 +0100 [thread overview]
Message-ID: <bdbb568d-0432-4d59-bd1f-cf2eb20bc2a1@linaro.org> (raw)
In-Reply-To: <875xay4h6y.fsf@pond.sub.org>
On 25/11/25 10:03, Markus Armbruster wrote:
> Markus Armbruster <armbru@redhat.com> writes:
>
>> Retrieve the @errno set by ioctl() before we call accel_ioctl_end()
>> instead of afterwards, so it works whether accel_ioctl_end() preserves
>> @errno or not.
>>
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>
> I did not check whether the assumption holds or not.
Indeed, on Linux the futex syscall is called via qemu_event_set.
> If it doesn't,
> then this needs
>
> Fixes: a27dd2de68f3 (KVM: keep track of running ioctls)
LGTM.
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2025-11-25 10:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-25 9:01 [PATCH] kvm: Don't assume accel_ioctl_end() preserves @errno Markus Armbruster
2025-11-25 9:03 ` Markus Armbruster
2025-11-25 10:33 ` Philippe Mathieu-Daudé [this message]
2025-11-25 11:40 ` Markus Armbruster
2025-11-25 10:37 ` Paolo Bonzini
2025-11-29 7:06 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bdbb568d-0432-4d59-bd1f-cf2eb20bc2a1@linaro.org \
--to=philmd@linaro.org \
--cc=armbru@redhat.com \
--cc=eesposit@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).