qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Max Reitz <mreitz@redhat.com>, qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH 2/2] iotests: Fix IMGOPTSSYNTAX for nbd
Date: Wed, 18 Dec 2019 15:11:54 +0100	[thread overview]
Message-ID: <bdc23d5c-089b-8db6-ef24-719b10bf7d98@redhat.com> (raw)
In-Reply-To: <20191218104855.42566-3-mreitz@redhat.com>

On 12/18/19 11:48 AM, Max Reitz wrote:
> There is no $SOCKDIR, only $SOCK_DIR.
> 
> Fixes: f3923a72f199b2c63747a7032db74730546f55c6
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
>   tests/qemu-iotests/common.rc | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.rc
> index ffb47c3d5c..d088392ab6 100644
> --- a/tests/qemu-iotests/common.rc
> +++ b/tests/qemu-iotests/common.rc
> @@ -217,7 +217,8 @@ if [ "$IMGOPTSSYNTAX" = "true" ]; then
>           TEST_IMG="$DRIVER,file.filename=$TEST_DIR/t.$IMGFMT"
>       elif [ "$IMGPROTO" = "nbd" ]; then
>           TEST_IMG_FILE=$TEST_DIR/t.$IMGFMT
> -        TEST_IMG="$DRIVER,file.driver=nbd,file.type=unix,file.path=$SOCKDIR/nbd"
> +        TEST_IMG="$DRIVER,file.driver=nbd,file.type=unix"
> +        TEST_IMG="$TEST_IMG,file.path=$SOCK_DIR/nbd"
>       elif [ "$IMGPROTO" = "ssh" ]; then
>           TEST_IMG_FILE=$TEST_DIR/t.$IMGFMT
>           TEST_IMG="$DRIVER,file.driver=ssh,file.host=127.0.0.1,file.path=$TEST_IMG_FILE"
> 

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>



  reply	other threads:[~2019-12-18 14:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-18 10:48 [PATCH 0/2] iotests: Minor fixes Max Reitz
2019-12-18 10:48 ` [PATCH 1/2] iotests/273: Filter format-specific information Max Reitz
2019-12-18 10:48 ` [PATCH 2/2] iotests: Fix IMGOPTSSYNTAX for nbd Max Reitz
2019-12-18 14:11   ` Philippe Mathieu-Daudé [this message]
2019-12-20 21:34   ` Eric Blake
2019-12-19 12:24 ` [PATCH 0/2] iotests: Minor fixes Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bdc23d5c-089b-8db6-ef24-719b10bf7d98@redhat.com \
    --to=philmd@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).