From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ED26FCD98E9 for ; Wed, 11 Oct 2023 03:11:22 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qqPcF-0007Tl-Q3; Tue, 10 Oct 2023 23:10:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qqPcD-0007SF-7y for qemu-devel@nongnu.org; Tue, 10 Oct 2023 23:10:29 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qqPcB-00033A-AK for qemu-devel@nongnu.org; Tue, 10 Oct 2023 23:10:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1696993825; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=arPOeIgvh/fj6AhPntuoa++rPQBVHTegohdvf4Qifvo=; b=D6WDQ0JEkYIFHrV/iUXDRJuG2qu42KAPqZtJu+fsZ/IL0OQew5/wYDO2B++ZUqg4wMslXX DnFrOssDJLUe621YxkskR6YwNNZ4RQhwywcGd5ybWAS3AIGThD4awLVAphknQES8EMi4lZ hhvxskdMclubAv48zBT44gCjPlO8xLE= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-390-RA2F0rOcNOOhcx1HlS7Lpg-1; Tue, 10 Oct 2023 23:10:24 -0400 X-MC-Unique: RA2F0rOcNOOhcx1HlS7Lpg-1 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-66d03b02d16so7288376d6.0 for ; Tue, 10 Oct 2023 20:10:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696993824; x=1697598624; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=arPOeIgvh/fj6AhPntuoa++rPQBVHTegohdvf4Qifvo=; b=owiHsTKOTi+oO3MrCWCVFrNP8IZkuDDzzmytngmFPTrX2rS00GFTuJTVHLELe7QWdj gtgPorPZq6F5s0zcOrJ8nK1SX7+CRmwluXlm1L3LP5cCq5nyE6o+CmwPK4yIPOX15RBi 3QcGlKyBo5Cpoc1UdeagoLZg5F5S3RVtqCOh/MTie2FsidTBZvVH/Rok8nCCBu7Cps4W emymTPq1aL3YBm6FsiZqQYQxkxRYWw3l0f2oC1j7ePGCKQBXaIAUrJaeARi1kXnoEXSI 1GQmnzyNXe2M+oJnVZeqHMAJsZByjFWSRQxhaKiyjoelwf15/NUYiOsxl5c6gIuRnSCe V0Pw== X-Gm-Message-State: AOJu0Yw4gJms01IR00iKqyBOA72qtilz6BJBZOd/Ccm/Lifp07ZEJhMz dZCNKZcCjS3saknnutqLTMq+hGsp5XTaKukUS0dfmG9CFxkSwYnaWux/rXKBZAe+HXlEoO2mHrV qYUVVthHt/u5rbj8= X-Received: by 2002:a0c:fa10:0:b0:66c:fd38:2266 with SMTP id q16-20020a0cfa10000000b0066cfd382266mr3156919qvn.25.1696993823986; Tue, 10 Oct 2023 20:10:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEwPGsI6ZN8nStepwIoJUp0Z9EnKlfl4KwsGy/tuGtX3U1rbP3WTrWRPHDyY4r62Lr8pFCCiQ== X-Received: by 2002:a0c:fa10:0:b0:66c:fd38:2266 with SMTP id q16-20020a0cfa10000000b0066cfd382266mr3156910qvn.25.1696993823683; Tue, 10 Oct 2023 20:10:23 -0700 (PDT) Received: from ?IPV6:2600:4040:7c46:e800:32a2:d966:1af4:8863? ([2600:4040:7c46:e800:32a2:d966:1af4:8863]) by smtp.gmail.com with ESMTPSA id d19-20020a0ce453000000b00655d6d31470sm5334457qvm.43.2023.10.10.20.10.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Oct 2023 20:10:22 -0700 (PDT) Message-ID: Date: Tue, 10 Oct 2023 23:10:22 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v2 1/9] Add Rust SEV library as subproject Content-Language: en-US To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org, pbonzini@redhat.com, mtosatti@redhat.com, philmd@linaro.org, berrange@redhat.com, marcandre.lureau@gmail.com References: <20231004203418.56508-1-tfanelli@redhat.com> <20231004203418.56508-2-tfanelli@redhat.com> <20231005155448.GA1342722@fedora> From: Tyler Fanelli In-Reply-To: <20231005155448.GA1342722@fedora> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=tfanelli@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 10/5/23 11:54 AM, Stefan Hajnoczi wrote: > On Wed, Oct 04, 2023 at 04:34:10PM -0400, Tyler Fanelli wrote: >> The Rust sev library provides a C API for the AMD SEV launch ioctls, as >> well as the ability to build with meson. Add the Rust sev library as a >> QEMU subproject with the goal of outsourcing all SEV launch ioctls to C >> APIs provided by it. >> >> Signed-off-by: Tyler Fanelli >> --- >> meson.build | 8 ++++++++ >> meson_options.txt | 2 ++ >> scripts/meson-buildoptions.sh | 3 +++ >> subprojects/sev.wrap | 6 ++++++ >> target/i386/meson.build | 2 +- >> 5 files changed, 20 insertions(+), 1 deletion(-) >> create mode 100644 subprojects/sev.wrap >> >> diff --git a/meson.build b/meson.build >> index 20ceeb8158..8a17c29de8 100644 >> --- a/meson.build >> +++ b/meson.build >> @@ -960,6 +960,13 @@ if not get_option('slirp').auto() or have_system >> endif >> endif >> >> +sev = not_found >> +if not get_option('sev').auto() > When 'sev' is auto, then it won't be built. That seems strange. The > auto-detection part is missing! I did you test this on a system that > doesn't have libsev installed system-wide? My testing environment had libsev installed system-wide. Thanks for pointing this out. > > I guess the auto-detection would look something like: > > cargo = find_program('cargo', required: true) > > if not get_option('sev').auto() or cargo.found() > ... > > That way 'sev' is only built automatically on systems that have cargo > installed. > >> + sev = dependency('sev', >> + method: 'pkg-config', >> + required: get_option('sev')) >> +endif > If you update the auto logic, see the documentation about fallbacks to > subprojects for optional dependencies: > https://mesonbuild.com/Wrap-dependency-system-manual.html#provide-section > > It might be necessary to add dependency(..., fallback='sev'). Noted. Thanks! > >> + >> vde = not_found >> if not get_option('vde').auto() or have_system or have_tools >> vde = cc.find_library('vdeplug', has_headers: ['libvdeplug.h'], >> @@ -4331,6 +4338,7 @@ summary_info += {'libudev': libudev} >> # Dummy dependency, keep .found() >> summary_info += {'FUSE lseek': fuse_lseek.found()} >> summary_info += {'selinux': selinux} >> +summary_info += {'sev': sev} >> summary_info += {'libdw': libdw} >> summary(summary_info, bool_yn: true, section: 'Dependencies') >> >> diff --git a/meson_options.txt b/meson_options.txt >> index 57e265c871..5b8d283717 100644 >> --- a/meson_options.txt >> +++ b/meson_options.txt >> @@ -204,6 +204,8 @@ option('sdl_image', type : 'feature', value : 'auto', >> description: 'SDL Image support for icons') >> option('seccomp', type : 'feature', value : 'auto', >> description: 'seccomp support') >> +option('sev', type : 'feature', value : 'auto', >> + description: 'Rust AMD SEV library') >> option('smartcard', type : 'feature', value : 'auto', >> description: 'CA smartcard emulation support') >> option('snappy', type : 'feature', value : 'auto', >> diff --git a/scripts/meson-buildoptions.sh b/scripts/meson-buildoptions.sh >> index e4b46d5715..e585a548fa 100644 >> --- a/scripts/meson-buildoptions.sh >> +++ b/scripts/meson-buildoptions.sh >> @@ -161,6 +161,7 @@ meson_options_help() { >> printf "%s\n" ' sdl-image SDL Image support for icons' >> printf "%s\n" ' seccomp seccomp support' >> printf "%s\n" ' selinux SELinux support in qemu-nbd' >> + printf "%s\n" ' sev SEV library support' >> printf "%s\n" ' slirp libslirp user mode network backend support' >> printf "%s\n" ' slirp-smbd use smbd (at path --smbd=*) in slirp networking' >> printf "%s\n" ' smartcard CA smartcard emulation support' >> @@ -440,6 +441,8 @@ _meson_option_parse() { >> --disable-seccomp) printf "%s" -Dseccomp=disabled ;; >> --enable-selinux) printf "%s" -Dselinux=enabled ;; >> --disable-selinux) printf "%s" -Dselinux=disabled ;; >> + --enable-sev) printf "%s" -Dsev=enabled ;; >> + --disable-sev) printf "%s" -Dsev=disabled ;; >> --enable-slirp) printf "%s" -Dslirp=enabled ;; >> --disable-slirp) printf "%s" -Dslirp=disabled ;; >> --enable-slirp-smbd) printf "%s" -Dslirp_smbd=enabled ;; >> diff --git a/subprojects/sev.wrap b/subprojects/sev.wrap >> new file mode 100644 >> index 0000000000..5be1faccf6 >> --- /dev/null >> +++ b/subprojects/sev.wrap >> @@ -0,0 +1,6 @@ >> +[wrap-git] >> +url = https://github.com/tylerfanelli/sev >> +revision = b81b1da5df50055600a5b0349b0c4afda677cccb >> + >> +[provide] >> +sev = sev_dep >> diff --git a/target/i386/meson.build b/target/i386/meson.build >> index 6f1036d469..8972a4fb17 100644 >> --- a/target/i386/meson.build >> +++ b/target/i386/meson.build >> @@ -20,7 +20,7 @@ i386_system_ss.add(files( >> 'monitor.c', >> 'cpu-sysemu.c', >> )) >> -i386_system_ss.add(when: 'CONFIG_SEV', if_true: files('sev.c'), if_false: files('sev-sysemu-stub.c')) >> +i386_system_ss.add(when: 'CONFIG_SEV', if_true: [sev, files('sev.c')], if_false: files('sev-sysemu-stub.c')) >> >> i386_user_ss = ss.source_set() >> >> -- >> 2.40.1 >> Tyler