From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60217) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bs6La-0006E9-PD for qemu-devel@nongnu.org; Thu, 06 Oct 2016 06:56:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bs6LW-0005fS-S6 for qemu-devel@nongnu.org; Thu, 06 Oct 2016 06:56:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54734) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bs6LW-0005f9-Ko for qemu-devel@nongnu.org; Thu, 06 Oct 2016 06:56:14 -0400 References: <1475706880-10667-1-git-send-email-cota@braap.org> From: Paolo Bonzini Message-ID: Date: Thu, 6 Oct 2016 12:56:10 +0200 MIME-Version: 1.0 In-Reply-To: <1475706880-10667-1-git-send-email-cota@braap.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/3] qht fixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Emilio G. Cota" , Peter Maydell Cc: "Daniel P . Berrange" , =?UTF-8?Q?Alex_Benn=c3=a9e?= , Richard Henderson , QEMU Developers On 06/10/2016 00:34, Emilio G. Cota wrote: > Patch 1 fixes a warning that gcc may unnecessarily emit. > > Patch 2 fixes a real bug that sometimes shows up as a segfault in test-qht. > Daniel reported it yesterday on IRC; the trick to easily trigger it is to > run on RHEL6 (or CentOS6). > It is very likely that this is the test-qht failure that Peter reported here: > https://lists.nongnu.org/archive/html/qemu-devel/2016-08/msg03771.html > (we cannot be 100% sure due to the lack of output there; however the fact that > it's the resize what fails supports the hypothesis that we're indeed hitting the > same bug.) > I'm therefore adding Peter's reported-by tag to the patch along with Daniel's. > > Patch 3 is merely good practice, since test-qht is single-threaded. However > I like having it, since test-qht serves as a de facto usage example > of qht. > > Given that patch 2 alone would conflict without previously applying patch 1, > I propose to merge both patches 1 & 2 to 2.7-stable. I'll send them to > qemu-stable once the patchset is picked up to be merged onto master. > > Thanks, > > Emilio > Queued, thanks. Paolo