From: David Woodhouse <dwmw2@infradead.org>
To: Claudio Fontana <cfontana@suse.de>,
"peter.maydell@linaro.org" <peter.maydell@linaro.org>,
"pbonzini@redhat.com" <pbonzini@redhat.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"alxndr@bu.edu" <alxndr@bu.edu>,
"philmd@redhat.com" <philmd@redhat.com>,
"ehabkost@redhat.com" <ehabkost@redhat.com>,
"lovemrd@gmail.com" <lovemrd@gmail.com>
Subject: Re: [PATCH for-6.1 v2] i386: do not call cpudef-only models functions for max, host, base
Date: Mon, 29 Nov 2021 19:19:24 +0000 [thread overview]
Message-ID: <bdd861f68aa1533b2ea752c6509c03ca7b9f0279.camel@infradead.org> (raw)
In-Reply-To: <483ebe21-2972-90c0-bc9a-ce922518632d@suse.de>
[-- Attachment #1: Type: text/plain, Size: 804 bytes --]
On Mon, 2021-11-29 at 20:10 +0100, Claudio Fontana wrote:
>
> Hmm I thought what you actually care for, for cpu "host", is just the kvm_enable_x2apic() call, not the kvm_default_props.
>
>
>
> Do you also expect the kvm_default_prop "kvm-msi-ext-dest-id" to be switch to "on" and applied?
It's already on today. It just isn't *true* because QEMU never called
kvm_enable_x2apic().
So what I care about (in case ∃ APIC IDs >= 255) is two things:
1. Qemu needs to call kvm_enable_x2apic().
2. If that *fails* qemu needs to *stop* advertising X2APIC and ext-dest-id.
That last patch snippet in pc_machine_done() should suffice to achieve
that, I think. Because if kvm_enable_x2apic() fails and qemu has been
asked for that many CPUs, it aborts completely. Which seems right.
[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5174 bytes --]
next prev parent reply other threads:[~2021-11-29 19:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-23 11:29 [PATCH for-6.1 v2] i386: do not call cpudef-only models functions for max, host, base Claudio Fontana
2021-11-29 11:39 ` Woodhouse, David
2021-11-29 14:14 ` Claudio Fontana
2021-11-29 15:11 ` David Woodhouse
2021-11-29 16:57 ` Claudio Fontana
2021-11-29 17:03 ` Claudio Fontana
2021-11-29 17:17 ` David Woodhouse
2021-11-29 19:10 ` Claudio Fontana
2021-11-29 19:19 ` David Woodhouse [this message]
2021-11-29 19:55 ` Claudio Fontana
2021-11-29 20:29 ` David Woodhouse
2021-11-30 9:00 ` Claudio Fontana
2021-11-30 12:13 ` David Woodhouse
2021-11-30 13:42 ` [PATCH 1/2] target/i386: Fix sanity check on max APIC ID / X2APIC enablement David Woodhouse
2021-11-30 13:42 ` [PATCH 2/2] intel_iommu: Fix irqchip / X2APIC configuration checks David Woodhouse
2021-11-30 14:31 ` Claudio Fontana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bdd861f68aa1533b2ea752c6509c03ca7b9f0279.camel@infradead.org \
--to=dwmw2@infradead.org \
--cc=alxndr@bu.edu \
--cc=cfontana@suse.de \
--cc=ehabkost@redhat.com \
--cc=lovemrd@gmail.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).