Re: [Qemu-devel] [PATCH] egl-helpers.h: add a missing X11 include

["Philippe Mathieu-Daudé" <philmd@redhat.com>]

Hi Alexander,

Cc'ing Gerd (the maintainer) and Marc-André.

On 1/15/19 12:50 PM, Alexander Kanavin wrote:
> Otherwise these errors occur, when qemu is built in the Yocto project:
> | In file included from /home/alexander/development/poky/build-virgl-gtk-64/tmp/work/x86_64-nativesdk-pokysdk-linux/nativesdk-qemu/3.1.0-r0/qemu-3.1.0/include/ui/egl-context.h:5,
> |                  from /home/alexander/development/poky/build-virgl-gtk-64/tmp/work/x86_64-nativesdk-pokysdk-linux/nativesdk-qemu/3.1.0-r0/qemu-3.1.0/ui/egl-context.c:3:
> | /home/alexander/development/poky/build-virgl-gtk-64/tmp/work/x86_64-nativesdk-pokysdk-linux/nativesdk-qemu/3.1.0-r0/qemu-3.1.0/include/ui/egl-helpers.h:46:55: error: unknown type name 'Window'; did you mean 'minor'?
> |  EGLSurface qemu_egl_init_surface_x11(EGLContext ectx, Window win);
> |                                                        ^~~~~~
> |                                                        minor

Can you provide more information to reproduce this failure?

It seems some dependency is missing in your build setup. Missing headers
would trigger the definition of MESA_EGL_NO_X11_HEADERS and this error.

<epoxy/egl.h> includes <EGL/eglplatform.h> which contains:

  #if defined(MESA_EGL_NO_X11_HEADERS)
  typedef void            *EGLNativeDisplayType;
  typedef khronos_uintptr_t EGLNativePixmapType;
  typedef khronos_uintptr_t EGLNativeWindowType;
  #else
  /* X11 (tentative)  */
  #include <X11/Xlib.h>

So Window should already be declared.

Thanks,

Phil.

> 
> Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
> ---
>  include/ui/egl-helpers.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/ui/egl-helpers.h b/include/ui/egl-helpers.h
> index 9db7293bdb..2c32d77e7a 100644
> --- a/include/ui/egl-helpers.h
> +++ b/include/ui/egl-helpers.h
> @@ -4,6 +4,7 @@
>  #include <epoxy/gl.h>
>  #include <epoxy/egl.h>
>  #include <gbm.h>
> +#include <X11/Xlib.h>
>  
>  extern EGLDisplay *qemu_egl_display;
>  extern EGLConfig qemu_egl_config;
>