From: Kevin Locke <kevin@kevinlocke.name>
To: qemu-devel@nongnu.org
Cc: Laszlo Ersek <lersek@redhat.com>,
Alex Williamson <alex.williamson@redhat.com>,
Marcel Apfelbaum <marcel@redhat.com>,
Laine Stump <laine@redhat.com>,
David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH v2] docs: add PCIe root bus for VGA compat guideline
Date: Sun, 12 Jun 2022 11:32:03 -0600 [thread overview]
Message-ID: <bde9fc450bc5143d616c7e9999c5d39ae9fd9cb8.1655054968.git.kevin@kevinlocke.name> (raw)
In-Reply-To: <922cc3081ff9c986188f881ef4d1cf15bd3adf48.1654739990.git.kevin@kevinlocke.name>
PCI Express devices which use legacy VGA compatibility should be placed
on the Root Complex. This simplifies ioport access to VGA registers,
which requires use of a special exception bit to work across PCI(e)
bridges. It is also necessary for ioport access to VESA BIOS Extension
(VBE) registers, which is not forwarded over PCI(e) bridges, even with
the special exception bit for VGA register access.[1]
Update the PCI Express Guidelines to add these to the list of devices
which can be placed directly on the Root Complex.
Note that the only PCI Express display devices currently supported
(bochs-display and virtio-gpu-pci) do not offer VGA compatibility.
Legacy PCI devices (e.g. vga, qxl-vga, virtio-vga) are already
documented as allowed on the Root Complex by the first item in the list.
However, this item documents an additional consideration for placing
devices which was not previously mentioned, and may be relevant for PCIe
devices offering VGA compatibility in the future.
[1]: https://mail.coreboot.org/hyperkitty/list/seabios@seabios.org/thread/XG2RN3HKVRDEDTLA2PRELLIENIIH7II7/#XVP3I2KQVZHSTDA4SNVKOITWGRGSDU3F
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
---
Changes since v1:
* Replace my overly-broad exception for devices requiring ioport access
with a list item specifically for PCI Express devices offering VGA
Compatibility provided by Laszlo Ersek.
* Rewrite the commit message based on my improved understanding of the
issue and the improved scope of the change.
P.S. Let me know if the Signed-off-by tag is not appropriate for either
of us. I'm not clear on the etiquette of including someone else's
sign-off, but also don't want to misrepresent myself as the source of
your work.
docs/pcie.txt | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/docs/pcie.txt b/docs/pcie.txt
index 89e3502075..59b26817f9 100644
--- a/docs/pcie.txt
+++ b/docs/pcie.txt
@@ -48,13 +48,17 @@ Place only the following kinds of devices directly on the Root Complex:
strangely when PCI Express devices are integrated
with the Root Complex.
- (2) PCI Express Root Ports (ioh3420), for starting exclusively PCI Express
+ (2) Assigned PCI Express GPUs that offer legacy VGA compatibility, and
+ that such compatibility is expected of (due to booting with SeaBIOS,
+ or due to UEFI driver bugs or native OS driver bugs).
+
+ (3) PCI Express Root Ports (ioh3420), for starting exclusively PCI Express
hierarchies.
- (3) PCI Express to PCI Bridge (pcie-pci-bridge), for starting legacy PCI
+ (4) PCI Express to PCI Bridge (pcie-pci-bridge), for starting legacy PCI
hierarchies.
- (4) Extra Root Complexes (pxb-pcie), if multiple PCI Express Root Buses
+ (5) Extra Root Complexes (pxb-pcie), if multiple PCI Express Root Buses
are needed.
pcie.0 bus
--
2.35.1
next prev parent reply other threads:[~2022-06-12 17:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-09 2:00 [RFC][PATCH] docs: note exception for PCIe IO port access Kevin Locke
2022-06-09 7:45 ` Laszlo Ersek
2022-06-09 7:50 ` Laszlo Ersek
2022-06-09 8:41 ` Gerd Hoffmann
2022-06-09 14:03 ` Kevin Locke
2022-06-10 7:00 ` Laszlo Ersek
2022-06-12 17:32 ` Kevin Locke [this message]
2022-06-13 13:47 ` [PATCH v2] docs: add PCIe root bus for VGA compat guideline Laszlo Ersek
2022-06-14 8:52 ` Gerd Hoffmann
2022-06-14 18:14 ` Kevin Locke
2022-06-15 6:42 ` Gerd Hoffmann
2022-06-15 20:05 ` Alex Williamson
2022-06-13 13:55 ` [PATCH v3] " Kevin Locke
2022-06-22 0:56 ` [PATCH v4] docs: mention devices with VBE on Root Complex Kevin Locke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bde9fc450bc5143d616c7e9999c5d39ae9fd9cb8.1655054968.git.kevin@kevinlocke.name \
--to=kevin@kevinlocke.name \
--cc=alex.williamson@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=laine@redhat.com \
--cc=lersek@redhat.com \
--cc=marcel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).