From: Alistair Francis <alistair.francis@xilinx.com>
To: qemu-devel@nongnu.org, edgar.iglesias@xilinx.com
Cc: edgar.iglesias@gmail.com, peter.crosthwaite@xilinx.com,
alistair.francis@xilinx.com
Subject: [Qemu-devel] [PATCH v4 8/9] s3adsp1800: Remove the hardcoded values from the reset
Date: Thu, 18 Jun 2015 21:16:48 -0700 [thread overview]
Message-ID: <bdf87e5e70fc20828df10cda8376ad5e23aaf305.1434686378.git.alistair.francis@xilinx.com> (raw)
In-Reply-To: <cover.1434686378.git.alistair.francis@xilinx.com>
Remove the hardcoded values from the machine specific reset
function, as the same values are already set in the standard
MicroBlaze reset.
This also allows the entire reset function to be deleted, as
PVR registers are now preserved on reset.
Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
Reviewed-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
---
hw/microblaze/petalogix_s3adsp1800_mmu.c | 9 +--------
1 files changed, 1 insertions(+), 8 deletions(-)
diff --git a/hw/microblaze/petalogix_s3adsp1800_mmu.c b/hw/microblaze/petalogix_s3adsp1800_mmu.c
index 84f6e74..7109e63 100644
--- a/hw/microblaze/petalogix_s3adsp1800_mmu.c
+++ b/hw/microblaze/petalogix_s3adsp1800_mmu.c
@@ -51,13 +51,6 @@
#define ETHLITE_IRQ 1
#define UARTLITE_IRQ 3
-static void machine_cpu_reset(MicroBlazeCPU *cpu)
-{
- CPUMBState *env = &cpu->env;
-
- env->pvr.regs[10] = 0x0c000000; /* spartan 3a dsp family. */
-}
-
static void
petalogix_s3adsp1800_init(MachineState *machine)
{
@@ -132,7 +125,7 @@ petalogix_s3adsp1800_init(MachineState *machine)
microblaze_load_kernel(cpu, ddr_base, ram_size,
machine->initrd_filename,
BINARY_DEVICE_TREE_FILE,
- machine_cpu_reset);
+ NULL);
}
static QEMUMachine petalogix_s3adsp1800_machine = {
--
1.7.1
next prev parent reply other threads:[~2015-06-19 4:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-19 4:16 [Qemu-devel] [PATCH v4 0/9] Extend Microblaze Properties Alistair Francis
2015-06-19 4:16 ` [Qemu-devel] [PATCH v4 1/9] target-microblaze: Rename the usefpu variable Alistair Francis
2015-06-19 4:16 ` [Qemu-devel] [PATCH v4 4/9] target-microblaze: Convert endi to a CPU property Alistair Francis
2015-06-19 4:16 ` [Qemu-devel] [PATCH v4 6/9] target-microblaze: Convert pvr-full " Alistair Francis
2015-06-19 4:16 ` [Qemu-devel] [PATCH v4 7/9] ml605_mmu: Move the hardcoded values to the init function Alistair Francis
2015-06-19 4:16 ` Alistair Francis [this message]
2015-06-19 4:16 ` [Qemu-devel] [PATCH v4 9/9] target-microblaze: Remove dead code Alistair Francis
2015-06-21 11:44 ` [Qemu-devel] [PATCH v4 0/9] Extend Microblaze Properties Edgar E. Iglesias
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bdf87e5e70fc20828df10cda8376ad5e23aaf305.1434686378.git.alistair.francis@xilinx.com \
--to=alistair.francis@xilinx.com \
--cc=edgar.iglesias@gmail.com \
--cc=edgar.iglesias@xilinx.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).