From: David Hildenbrand <david@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
"Juan Quintela" <quintela@redhat.com>,
"Peter Xu" <peterx@redhat.com>,
"Leonardo Bras" <leobras@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Peng Tao" <tao.peng@linux.alibaba.com>,
"Mario Casquero" <mcasquer@redhat.com>
Subject: Re: [PATCH v2 1/4] softmmu/physmem: Warn with ram_block_discard_range() on MAP_PRIVATE file mapping
Date: Thu, 6 Jul 2023 10:49:48 +0200 [thread overview]
Message-ID: <be03090f-7203-bd70-b984-dd797718a86e@redhat.com> (raw)
In-Reply-To: <20230706075612.67404-2-david@redhat.com>
> #ifdef CONFIG_FALLOCATE_PUNCH_HOLE
> + /*
> + * We'll discard data from the actual file, even though we only
> + * have a MAP_PRIVATE mapping, possibly messing with other
> + * MAP_PRIVATE/MAP_SHARED mappings. There is no easy way to
> + * change that behavior whithout violating the promised
> + * semantics of ram_block_discard_range().
> + *
> + * Only warn, because it work as long as nobody else uses that
>
I'll fixup
s/work/works/
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2023-07-06 8:50 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-06 7:56 [PATCH v2 0/4] virtio-mem: Support "x-ignore-shared" migration David Hildenbrand
2023-07-06 7:56 ` [PATCH v2 1/4] softmmu/physmem: Warn with ram_block_discard_range() on MAP_PRIVATE file mapping David Hildenbrand
2023-07-06 8:10 ` Juan Quintela
2023-07-06 8:31 ` David Hildenbrand
2023-07-06 13:20 ` Juan Quintela
2023-07-06 13:23 ` David Hildenbrand
2023-07-06 8:49 ` David Hildenbrand [this message]
2023-10-18 3:02 ` Xiaoyao Li
2023-10-18 7:42 ` David Hildenbrand
2023-10-18 9:02 ` Xiaoyao Li
2023-10-18 9:26 ` David Hildenbrand
2023-10-18 16:27 ` Xiaoyao Li
2023-10-19 8:26 ` David Hildenbrand
2023-10-19 9:26 ` Xiaoyao Li
2023-10-19 9:43 ` David Hildenbrand
2023-07-06 7:56 ` [PATCH v2 2/4] virtio-mem: Skip most of virtio_mem_unplug_all() without plugged memory David Hildenbrand
2023-07-06 8:15 ` Juan Quintela
2023-07-06 8:38 ` David Hildenbrand
2023-07-06 13:27 ` Juan Quintela
2023-07-06 7:56 ` [PATCH v2 3/4] migration/ram: Expose ramblock_is_ignored() as migrate_ram_is_ignored() David Hildenbrand
2023-07-06 8:16 ` Juan Quintela
2023-07-06 7:56 ` [PATCH v2 4/4] virtio-mem: Support "x-ignore-shared" migration David Hildenbrand
2023-07-06 11:06 ` Juan Quintela
2023-07-06 11:27 ` David Hildenbrand
2023-07-06 11:59 ` Juan Quintela
2023-07-06 14:03 ` [PATCH v2 0/4] " Michael S. Tsirkin
2023-07-07 12:21 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be03090f-7203-bd70-b984-dd797718a86e@redhat.com \
--to=david@redhat.com \
--cc=leobras@redhat.com \
--cc=mcasquer@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=tao.peng@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).