From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB2C7C43603 for ; Wed, 11 Dec 2019 16:18:43 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 71C70205C9 for ; Wed, 11 Dec 2019 16:18:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="IGUNXuEH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 71C70205C9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:45364 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1if4hG-0003hs-Gu for qemu-devel@archiver.kernel.org; Wed, 11 Dec 2019 11:18:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:43672) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1if4ca-0000bv-8H for qemu-devel@nongnu.org; Wed, 11 Dec 2019 11:13:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1if4cY-0006wv-Vc for qemu-devel@nongnu.org; Wed, 11 Dec 2019 11:13:52 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:20994 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1if4cY-0006wW-R9 for qemu-devel@nongnu.org; Wed, 11 Dec 2019 11:13:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576080830; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OL0aRlGSKpSoTMVlNBUVPkab/a9UZhPdcE01fU1VNlQ=; b=IGUNXuEHyHXQlzhvQ9u+cOBNVhbas8KUEUsvpFO9TJqrjNt4E7ETavEcA0h/MEaJXaCPoK kIuovr5zYMPMsqfQuHBuqJcolwBpBlPd/Dpvbw9pAX6BCsUUOI40UWAbuGyLeNkH9mNElL HxAQIkz/y/vWqGrMQkL0O3ktdj7zIas= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-295-W44nSYBONOGd_0gddWO91g-1; Wed, 11 Dec 2019 11:13:49 -0500 Received: by mail-wr1-f71.google.com with SMTP id o6so10590002wrp.8 for ; Wed, 11 Dec 2019 08:13:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3Dk48f+905tu40fuiA0Wi7X06wQ57iExGYr6Vzkp7Jc=; b=T5aWtFfdv2hVFpXw0h5L6OO/xnZH3+7deRI7nEK09wZHIXlBzLuOLHg7POEYxN+Dh+ GgGLdQ3aIpybZ3XxVHsKDTtB3Evt2iNoL9amahYyBOg55PCwHnqS3G9PHiVGnf3toLVj ap5Ble60mRJ8m4IBo/OeSdoa11r2gBZDdAb4R6iD4hEUEbm7+Ec1j5WMrI7nGW0gQ9r2 zD0nsSpnMyUUzlN61v7IhFz4lU4CJ7Uud/8vRjjOJEaiEdznpKJG4C5YkDBIDaNlKyLa X67ryPrQr+c/zenc/gw6WOmj8iC/5r5q9g7GEapZc2j+z3iA4UseSitRmxoUj3Rbjmfx iEqw== X-Gm-Message-State: APjAAAWS3DBjbM7pEgKKcpBcVusMVfhFApczZTzRVtHm5dxXTREzLuMs en29Wv50J8THd4qeEpFGsWVPceGlKY2hNTGNZlgEz/Sg1SE8zYXr80tNu4Mf9UVd939yAFCdSyl 5D/na9hSVSvoMBcE= X-Received: by 2002:a7b:ce81:: with SMTP id q1mr640975wmj.47.1576080827637; Wed, 11 Dec 2019 08:13:47 -0800 (PST) X-Google-Smtp-Source: APXvYqzl5+3whZ0/OuGxpc8u0LnfF1Ws2r7sjoBSBqIbMs0bMprtY7HI0bVfZS5qZDM6nzJc2c2RPw== X-Received: by 2002:a7b:ce81:: with SMTP id q1mr640944wmj.47.1576080827391; Wed, 11 Dec 2019 08:13:47 -0800 (PST) Received: from [10.201.33.164] ([195.166.127.210]) by smtp.gmail.com with ESMTPSA id b185sm3028847wme.36.2019.12.11.08.13.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Dec 2019 08:13:46 -0800 (PST) Subject: Re: [PATCH v2] ppc/pnv: Make PnvXScomInterface an incomplete type To: Greg Kurz , David Gibson References: <157608025541.186670.1577861507610404326.stgit@bahia.lan> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: Date: Wed, 11 Dec 2019 17:13:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <157608025541.186670.1577861507610404326.stgit@bahia.lan> Content-Language: en-US X-MC-Unique: W44nSYBONOGd_0gddWO91g-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-ppc@nongnu.org, =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 12/11/19 5:04 PM, Greg Kurz wrote: > PnvXScomInterface is an interface instance. It should never be > dereferenced. Drop the dummy type definition for extra safety, > which is the common practice with QOM interfaces. >=20 > While here also convert the bogus OBJECT_CHECK() to INTERFACE_CHECK(). >=20 > Signed-off-by: Greg Kurz Reviewed-by: Philippe Mathieu-Daud=C3=A9 > --- > v2: convert OBJECT_CHECK() to INTERFACE_CHECK() > --- > include/hw/ppc/pnv_xscom.h | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) >=20 > diff --git a/include/hw/ppc/pnv_xscom.h b/include/hw/ppc/pnv_xscom.h > index 1c1d76bf9be5..306c22461587 100644 > --- a/include/hw/ppc/pnv_xscom.h > +++ b/include/hw/ppc/pnv_xscom.h > @@ -22,13 +22,11 @@ > =20 > #include "qom/object.h" > =20 > -typedef struct PnvXScomInterface { > - Object parent; > -} PnvXScomInterface; > +typedef struct PnvXScomInterface PnvXScomInterface; > =20 > #define TYPE_PNV_XSCOM_INTERFACE "pnv-xscom-interface" > #define PNV_XSCOM_INTERFACE(obj) \ > - OBJECT_CHECK(PnvXScomInterface, (obj), TYPE_PNV_XSCOM_INTERFACE) > + INTERFACE_CHECK(PnvXScomInterface, (obj), TYPE_PNV_XSCOM_INTERFACE) > #define PNV_XSCOM_INTERFACE_CLASS(klass) \ > OBJECT_CLASS_CHECK(PnvXScomInterfaceClass, (klass), \ > TYPE_PNV_XSCOM_INTERFACE) >=20 >=20