From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E1C36EB64D7 for ; Fri, 30 Jun 2023 08:54:29 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qF9tF-0006ha-Nt; Fri, 30 Jun 2023 04:54:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qF9tE-0006hE-0g for qemu-devel@nongnu.org; Fri, 30 Jun 2023 04:54:04 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qF9tB-0006kc-MU for qemu-devel@nongnu.org; Fri, 30 Jun 2023 04:54:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688115241; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Eexfi3cN4sBlnidXGYW3Y0ewmh7sIwKaxuNlkoKglFA=; b=AnAJkUvIGZG0z7GkON9o9C8gib1kZC2OcW4uf7hzLcjPiTk8bsi6zV7DhBXtQ04QKoWDvQ UvQKzIxQvyvhWt/sHJEqtA/GQ80gxks9Mdi3nHelch73clrXivwBaASVDCubdtc1XPPIOj yleCUpbgQ2+pV+18lEXNXacitCY3Ros= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-561-3WaJlAOYNDe-GEcoAxsJ9g-1; Fri, 30 Jun 2023 04:53:59 -0400 X-MC-Unique: 3WaJlAOYNDe-GEcoAxsJ9g-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-3f7e4dc0fe5so9076725e9.3 for ; Fri, 30 Jun 2023 01:53:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688115238; x=1690707238; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Eexfi3cN4sBlnidXGYW3Y0ewmh7sIwKaxuNlkoKglFA=; b=Zf9PoWta9zhQBvqjCjHBcmMzqVjpQ7oOBJNN1shdyx3fAzkA2khtEIgHvL964Hifb+ d1RColYUWTIFpYqM3r97bXZUZALnDTpKXfNL6YVKJdx9DrY2hG6S3R6tg+fp7aBGtpKq kyQW6Kh1AnvqpPPN17BX/WrwL8mDipJwWKHizSncPykyFlQJJp0SMqigMwOpHSTmNbHi jRM2gGGxNJJedgeW5aIXWkD8zSy/R8Noz1A4bv0IwbJyVry75i+W/a2j32ksqSKyMWbI IeMEXmoZ6B8DsDhmKS/UWhaEWzLWMVE8ZQ6Ys9V2wtaX9hOg9HRFePPDDCyoPIpscIKv +VIA== X-Gm-Message-State: AC+VfDyhav0tUgG2XLN0uZYWvFzIvSU7Qkww9cTq/VuhxBntcKvCzJtY Ty26llRASACWpqI0cAqRily37yMNYaS3JkBZvz7E72FGSI+MFOVk4uj4hcldtUXp9BgnnURXfsl a2eRC0sTKIKx2kgc= X-Received: by 2002:a7b:c7c7:0:b0:3fb:b1bb:a0c1 with SMTP id z7-20020a7bc7c7000000b003fbb1bba0c1mr1468941wmk.37.1688115238315; Fri, 30 Jun 2023 01:53:58 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5TwoNiQsxbrI4V6oAz3nGl1WJqd9mzgzAfD3Q2LosCzT0gkJvmOMl/yIuZLXKbS13clPUlow== X-Received: by 2002:a7b:c7c7:0:b0:3fb:b1bb:a0c1 with SMTP id z7-20020a7bc7c7000000b003fbb1bba0c1mr1468925wmk.37.1688115237926; Fri, 30 Jun 2023 01:53:57 -0700 (PDT) Received: from [192.168.8.100] (tmo-102-161.customers.d1-online.com. [80.187.102.161]) by smtp.gmail.com with ESMTPSA id b7-20020a5d45c7000000b003141a3c4353sm3191584wrs.30.2023.06.30.01.53.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Jun 2023 01:53:57 -0700 (PDT) Message-ID: Date: Fri, 30 Jun 2023 10:53:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PULL 18/42] tests: avocado: boot_linux_console: Add test case for bpim2u Content-Language: en-US To: qianfan , Peter Maydell , qemu-devel@nongnu.org Cc: Niek Linnenbank , Richard Henderson , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= References: <20230606094814.3581397-1-peter.maydell@linaro.org> <20230606094814.3581397-19-peter.maydell@linaro.org> <280c57d2-9648-36ea-74e9-6ffc7f3b4388@redhat.com> <4f749512-a395-40e4-c20e-ed4928c2cb87@redhat.com> From: Thomas Huth In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.093, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 30/06/2023 10.45, qianfan wrote: > > > 在 2023/6/30 15:27, Thomas Huth 写道: >> On 30/06/2023 08.15, qianfan wrote: >>> >>> >>> 在 2023/6/29 19:35, Thomas Huth 写道: >>>> On 06/06/2023 11.47, Peter Maydell wrote: >>>>> From: qianfan Zhao >>>>> >>>>> Add test case for booting from initrd and sd card. >>>>> >>>>> Signed-off-by: qianfan Zhao >>>>> Reviewed-by: Niek Linnenbank >>>>> Tested-by: Niek Linnenbank >>>>> Signed-off-by: Peter Maydell >>>>> --- >>>>>   tests/avocado/boot_linux_console.py | 176 ++++++++++++++++++++++++++++ >>>>>   1 file changed, 176 insertions(+) >>>> ... >>>>> +    def test_arm_bpim2u_gmac(self): >>>>> +        """ >>>>> +        :avocado: tags=arch:arm >>>>> +        :avocado: tags=accel:tcg >>>>> +        :avocado: tags=machine:bpim2u >>>>> +        :avocado: tags=device:sd >>>>> +        """ >>>>> +        self.require_netdev('user') >>>>> + >>>>> +        deb_url = >>>>> ('https://apt.armbian.com/pool/main/l/linux-5.10.16-sunxi/' >>>>> + 'linux-image-current-sunxi_21.02.2_armhf.deb') >>>>> +        deb_hash = '9fa84beda245cabf0b4fa84cf6eaa7738ead1da0' >>>>> +        deb_path = self.fetch_asset(deb_url, asset_hash=deb_hash) >>>>> +        kernel_path = self.extract_from_deb(deb_path, >>>>> + '/boot/vmlinuz-5.10.16-sunxi') >>>>> +        dtb_path = ('/usr/lib/linux-image-current-sunxi/' >>>>> +                    'sun8i-r40-bananapi-m2-ultra.dtb') >>>>> +        dtb_path = self.extract_from_deb(deb_path, dtb_path) >>>>> +        rootfs_url = >>>>> ('http://storage.kernelci.org/images/rootfs/buildroot/' >>>>> + 'buildroot-baseline/20221116.0/armel/rootfs.ext2.xz') >>>>> +        rootfs_hash = 'fae32f337c7b87547b10f42599acf109da8b6d9a' >>>>> +        rootfs_path_xz = self.fetch_asset(rootfs_url, >>>>> asset_hash=rootfs_hash) >>>>> +        rootfs_path = os.path.join(self.workdir, 'rootfs.cpio') >>>>> +        archive.lzma_uncompress(rootfs_path_xz, rootfs_path) >>>>> +        image_pow2ceil_expand(rootfs_path) >>>>> + >>>>> +        self.vm.set_console() >>>>> +        kernel_command_line = (self.KERNEL_COMMON_COMMAND_LINE + >>>>> +                               'console=ttyS0,115200 ' >>>>> +                               'root=/dev/mmcblk0 rootwait rw ' >>>>> +                               'panic=-1 noreboot') >>>>> +        self.vm.add_args('-kernel', kernel_path, >>>>> +                         '-dtb', dtb_path, >>>>> +                         '-drive', 'file=' + rootfs_path + >>>>> ',if=sd,format=raw', >>>>> +                         '-net', 'nic,model=gmac,netdev=host_gmac', >>>>> +                         '-netdev', 'user,id=host_gmac', >>>>> +                         '-append', kernel_command_line, >>>>> +                         '-no-reboot') >>>>> +        self.vm.launch() >>>>> +        shell_ready = "/bin/sh: can't access tty; job control turned off" >>>>> +        self.wait_for_console_pattern(shell_ready) >>>>> + >>>>> +        exec_command_and_wait_for_pattern(self, 'cat /proc/cpuinfo', >>>>> +                                                'Allwinner sun8i Family') >>>>> +        exec_command_and_wait_for_pattern(self, 'cat /proc/partitions', >>>>> +                                                'mmcblk0') >>>>> +        exec_command_and_wait_for_pattern(self, 'ifconfig eth0 up', >>>>> +                                                 'eth0: Link is Up') >>>>> +        exec_command_and_wait_for_pattern(self, 'udhcpc eth0', >>>>> +            'udhcpc: lease of 10.0.2.15 obtained') >>>>> +        exec_command_and_wait_for_pattern(self, 'ping -c 3 10.0.2.2', >>>>> +            '3 packets transmitted, 3 packets received, 0% packet loss') >>>>> +        exec_command_and_wait_for_pattern(self, 'reboot', >>>>> +                                                'reboot: Restarting >>>>> system') >>>>> +        # Wait for VM to shut down gracefully >>>>> +        self.vm.wait() >>>> >>>> FYI, the test_arm_bpim2u_gmac test just failed during one of my CI runs: >>>> >>>> https://gitlab.com/thuth/qemu/-/jobs/4565108610#L300 >>>> >>>> Looking at the debug.log in the artifacts, it looks like the kernel was >>>> hanging during boot: >>>> >>>> 10:53:56 DEBUG| of_cfs_init >>>> 10:53:56 DEBUG| of_cfs_init: OK >>>> 10:53:56 DEBUG| ALSA device list: >>>> 10:53:56 DEBUG| No soundcards found. >>>> 10:53:56 DEBUG| Waiting for root device /dev/mmcblk0... >>>> 10:54:26 DEBUG| dcdc4: disabling >>>> 10:54:26 DEBUG| dc5ldo: disabling >>>> 10:54:26 DEBUG| vcc5v0: disabling >>>> 10:55:15 ERROR| >>>> ... >>>> 10:55:15 ERROR| RuntimeError: Test interrupted by SIGTERM >>>> >>>> I can reproduce the problem locally on my laptop when running the test >>>> repeatedly, e.g. with: >>>> >>>>  make check-venv >>>>  for ((x=0;x<10;x++)); do \ >>>>   ./tests/venv/bin/avocado run \ >>>>     tests/avocado/boot_linux_console.py:test_arm_bpim2u_gmac ; \ >>>>  done >>>> >>>> 1 out of 10 runs were failing. >>>> >>>> Any ideas what could be wrong in those failing cases? >>> Hi: >>> >>> I can reproduce this issue based on master >>> code(v8.0.0-rc1-2442-g4d541f63e9) with your's >>> test scripts, and I have tested 50 times only failed once. >>> >>> Copy liunx boot logs and make a diff: >>> >>> $ diff ~/a/qemu_bpi_good.txt ~/a/qemu_bpi_bad.txt >> ... >>> 288a289,291 >>>  > mmc1: host does not support reading read-only switch, assuming >>> write-enable >>>  > mmc1: new high speed SD card at address 4567 >>>  > mmcblk1: mmc1:4567 QEMU! 64.0 MiB >>> 296,298d298 >>> < mmc0: host does not support reading read-only switch, assuming >>> write-enable >>> < mmc0: new high speed SD card at address 4567 >>> < mmcblk0: mmc0:4567 QEMU! 64.0 MiB >>> 322,331c322,325 >>> < EXT4-fs (mmcblk0): mounting ext2 file system using the ext4 subsystem >>> < EXT4-fs (mmcblk0): mounted filesystem without journal. Opts: (null) >>> < VFS: Mounted root (ext2 filesystem) on device 179:0. >>> < devtmpfs: mounted >>> < Freeing unused kernel memory: 1024K >>> < Run /sbin/init as init process >>> < EXT4-fs (mmcblk0): re-mounted. Opts: (null) >>> < Starting syslogd: OK >>> < Starting klogd: OK >>> < Running sysctl: OK >>> \ No newline at end of file >>> --- >>>  > Waiting for root device /dev/mmcblk0... >>>  > dcdc4: disabling >>>  > dc5ldo: disabling >>>  > vcc5v0: disabling >>> \ No newline at end of file >>> >>> The first mmc device should be mmc0, but the linux kernel named it as >>> mmcblk1. >>> So it always 'Waiting for root device /dev/mmcblk0...', that make the rootfs >>> can not mounted. >>> >>> I'm not make sure where the problem came from. >> >> Oh, that's ugly, I think the problem is likely that the numbering >> of device names that are directly in /dev/ is never guaranteed by >> the Linux kernel. >> >> Could you please try whether this work more reliably for you >> instead: >> >> diff a/tests/avocado/boot_linux_console.py >> b/tests/avocado/boot_linux_console.py >> --- a/tests/avocado/boot_linux_console.py >> +++ b/tests/avocado/boot_linux_console.py >> @@ -869,7 +869,7 @@ def test_arm_bpim2u_gmac(self): >>          self.vm.set_console() >>          kernel_command_line = (self.KERNEL_COMMON_COMMAND_LINE + >>                                 'console=ttyS0,115200 ' >> -                               'root=/dev/mmcblk0 rootwait rw ' >> +                               'root=b300 rootwait rw ' >>                                 'panic=-1 noreboot') >>          self.vm.add_args('-kernel', kernel_path, >>                           '-dtb', dtb_path, >> >> ? > Yes, this patch is useful. > > The rootfs can mount successful even if the mmc block enumed as mmcblk1, > next is the > kernel logs: > > mmc1: new high speed SD card at address 4567 > mmcblk1: mmc1:4567 QEMU! 64.0 MiB > EXT4-fs (mmcblk1): mounting ext2 file system using the ext4 subsystem > EXT4-fs (mmcblk1): mounted filesystem without journal. Opts: (null) > VFS: Mounted root (ext2 filesystem) on device 179:0. Great! > But the test scripts still fail due to it always waiting mmc0blk: > >     exec_command_and_wait_for_pattern(self, 'cat /proc/partitions', 'mmcblk0') Ok, so the "0" likely got to be dropped here? > Could you please explain where is the "b300" come from? I ran the kernel once without the "root=/dev/mmcblk0 rootwait" part in its command line. Then it prints out something like this: VFS: Cannot open root device "(null)" or unknown-block(0,0): error -6 Please append a correct "root=" boot option; here are the available partitions: 0100 4096 ram0 (driver?) 0101 4096 ram1 (driver?) 0102 4096 ram2 (driver?) 0103 4096 ram3 (driver?) b300 65536 mmcblk0 driver: mmcblk Kernel panic - not syncing: VFS: Unable to mount root fs on unknown-block(0,0) Seems like the "b300" is stable here, no matter whether its mmcblk0 or mmcblk1. Thomas