From: Stefan Berger <stefanb@linux.ibm.com>
To: Ninad Palsule <ninad@linux.ibm.com>, qemu-devel@nongnu.org
Cc: joel@jms.id.au, andrew@aj.id.au, clg@kaod.org
Subject: Re: [PATCH v10 2/3] tpm: Extend common APIs to support TPM TIS I2C
Date: Mon, 27 Mar 2023 15:57:33 -0400 [thread overview]
Message-ID: <be0e380e-c033-7e14-c760-b13101130d0d@linux.ibm.com> (raw)
In-Reply-To: <20230327183350.4060507-3-ninad@linux.ibm.com>
On 3/27/23 14:33, Ninad Palsule wrote:
> Qemu already supports devices attached to ISA and sysbus. This drop adds
> support for the I2C bus attached TPM devices.
>
> This commit includes changes for the common code.
> - Added support for the new checksum registers which are required for
> the I2C support. The checksum calculation is handled in the qemu
> common code.
> - Added wrapper function for read and write data so that I2C code can
> call it without MMIO interface.
>
> The TPM TIS I2C spec describes in the table in section "Interface Locality
> Usage per Register" that the TPM_INT_ENABLE and TPM_INT_STATUS registers
> must be writable for any locality even if the locality is not the active
> locality. Therefore, remove the checks whether the writing locality is the
> active locality for these registers.
>
> Signed-off-by: Ninad Palsule <ninad@linux.ibm.com>
> Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>
Tested-by: Stefan Berger <stefanb@linux.ibm.com>
next prev parent reply other threads:[~2023-03-27 19:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 18:33 [PATCH v10 0/3] Add support for TPM devices over I2C bus Ninad Palsule
2023-03-27 18:33 ` [PATCH v10 1/3] docs: " Ninad Palsule
2023-03-27 19:56 ` Stefan Berger
2023-03-28 6:25 ` Cédric Le Goater
2023-03-27 18:33 ` [PATCH v10 2/3] tpm: Extend common APIs to support TPM TIS I2C Ninad Palsule
2023-03-27 19:57 ` Stefan Berger [this message]
2023-03-28 6:26 ` Cédric Le Goater
2023-03-27 18:33 ` [PATCH v10 3/3] tpm: Add support for TPM device over I2C bus Ninad Palsule
2023-03-27 19:59 ` Stefan Berger
2023-03-28 6:31 ` Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be0e380e-c033-7e14-c760-b13101130d0d@linux.ibm.com \
--to=stefanb@linux.ibm.com \
--cc=andrew@aj.id.au \
--cc=clg@kaod.org \
--cc=joel@jms.id.au \
--cc=ninad@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).