From: Eric Blake <eblake@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: "nsoffer@redhat.com" <nsoffer@redhat.com>,
"rjones@redhat.com" <rjones@redhat.com>,
"jsnow@redhat.com" <jsnow@redhat.com>,
"qemu-block@nongnu.org" <qemu-block@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v3 14/19] nbd/client: Pull out oldstyle size determination
Date: Wed, 16 Jan 2019 13:47:50 -0600 [thread overview]
Message-ID: <be13579b-6007-a6f4-3e04-f54d01033cb5@redhat.com> (raw)
In-Reply-To: <cca07ea7-4778-1469-fd36-b6f4f7691476@virtuozzo.com>
[-- Attachment #1: Type: text/plain, Size: 991 bytes --]
On 1/15/19 9:35 AM, Vladimir Sementsov-Ogievskiy wrote:
> 12.01.2019 20:58, Eric Blake wrote:
>> Another refactoring creating nbd_negotiate_finish_oldstyle()
>> for further reuse during 'qemu-nbd --list'.
>>
>> Signed-off-by: Eric Blake <eblake@redhat.com>
>> Message-Id: <20181215135324.152629-18-eblake@redhat.com>
>> Reviewed-by: Richard W.M. Jones <rjones@redhat.com>
>
> Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
>
> Hmm, looking at this, I found that nbd_start_negotiate() has very unusual semantics
> for @zeroes field, without any comment about it:
>
> It must be set to true before calling, and nbd_start_negotiate may set it to true.
>
> I think better is not to rely on caller initialization and set zeroes to true at the
> beginning of nbd_start_negotiate().
Makes sense; done in my local tree.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-01-16 19:48 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-12 17:57 [Qemu-devel] [PATCH v3 00/19] nbd: add qemu-nbd --list Eric Blake
2019-01-12 17:57 ` [Qemu-devel] [PATCH v3 01/19] maint: Allow for EXAMPLES in texi2pod Eric Blake
2019-01-15 17:51 ` Richard W.M. Jones
2019-01-12 17:57 ` [Qemu-devel] [PATCH v3 02/19] qemu-nbd: Enhance man page Eric Blake
2019-01-15 17:53 ` Richard W.M. Jones
2019-01-12 17:57 ` [Qemu-devel] [PATCH v3 03/19] qemu-nbd: Sanity check partition bounds Eric Blake
2019-01-15 16:20 ` Vladimir Sementsov-Ogievskiy
2019-01-15 16:53 ` Eric Blake
2019-01-15 18:00 ` Richard W.M. Jones
2019-01-15 18:08 ` Eric Blake
2019-01-16 7:46 ` Vladimir Sementsov-Ogievskiy
2019-01-12 17:57 ` [Qemu-devel] [PATCH v3 04/19] nbd/server: Hoist length check to qemp_nbd_server_add Eric Blake
2019-01-15 9:44 ` Vladimir Sementsov-Ogievskiy
2019-01-15 15:25 ` Eric Blake
2019-01-15 16:26 ` Vladimir Sementsov-Ogievskiy
2019-01-15 16:58 ` Eric Blake
2019-01-16 18:03 ` Eric Blake
2019-01-16 18:05 ` Eric Blake
2019-01-12 17:57 ` [Qemu-devel] [PATCH v3 05/19] nbd/server: Favor [u]int64_t over off_t Eric Blake
2019-01-15 10:19 ` Vladimir Sementsov-Ogievskiy
2019-01-15 15:33 ` Eric Blake
2019-01-15 15:41 ` Vladimir Sementsov-Ogievskiy
2019-01-16 8:23 ` Vladimir Sementsov-Ogievskiy
2019-01-16 14:23 ` Eric Blake
2019-01-12 17:57 ` [Qemu-devel] [PATCH v3 06/19] qemu-nbd: Avoid strtol open-coding Eric Blake
2019-01-15 12:31 ` Vladimir Sementsov-Ogievskiy
2019-01-15 15:35 ` Eric Blake
2019-01-15 18:09 ` Richard W.M. Jones
2019-01-12 17:58 ` [Qemu-devel] [PATCH v3 07/19] nbd/client: Refactor nbd_receive_list() Eric Blake
2019-01-12 17:58 ` [Qemu-devel] [PATCH v3 08/19] nbd/client: Move export name into NBDExportInfo Eric Blake
2019-01-12 17:58 ` [Qemu-devel] [PATCH v3 09/19] nbd/client: Change signature of nbd_negotiate_simple_meta_context() Eric Blake
2019-01-12 17:58 ` [Qemu-devel] [PATCH v3 10/19] nbd/client: Split out nbd_send_one_meta_context() Eric Blake
2019-01-15 13:18 ` Vladimir Sementsov-Ogievskiy
2019-01-15 15:44 ` Eric Blake
2019-01-15 15:52 ` Vladimir Sementsov-Ogievskiy
2019-01-15 15:55 ` Eric Blake
2019-01-15 15:59 ` Vladimir Sementsov-Ogievskiy
2019-01-16 10:40 ` Vladimir Sementsov-Ogievskiy
2019-01-12 17:58 ` [Qemu-devel] [PATCH v3 11/19] nbd/client: Split out nbd_receive_one_meta_context() Eric Blake
2019-01-15 15:05 ` Vladimir Sementsov-Ogievskiy
2019-01-15 15:50 ` Eric Blake
2019-01-15 15:53 ` Vladimir Sementsov-Ogievskiy
2019-01-12 17:58 ` [Qemu-devel] [PATCH v3 12/19] nbd/client: Refactor return of nbd_receive_negotiate() Eric Blake
2019-01-12 17:58 ` [Qemu-devel] [PATCH v3 13/19] nbd/client: Split handshake into two functions Eric Blake
2019-01-15 15:34 ` Vladimir Sementsov-Ogievskiy
2019-01-12 17:58 ` [Qemu-devel] [PATCH v3 14/19] nbd/client: Pull out oldstyle size determination Eric Blake
2019-01-15 15:35 ` Vladimir Sementsov-Ogievskiy
2019-01-15 15:45 ` Vladimir Sementsov-Ogievskiy
2019-01-16 19:47 ` Eric Blake [this message]
2019-01-12 17:58 ` [Qemu-devel] [PATCH v3 15/19] nbd/client: Add nbd_receive_export_list() Eric Blake
2019-01-16 10:15 ` Vladimir Sementsov-Ogievskiy
2019-01-16 14:33 ` Eric Blake
2019-01-16 20:01 ` Eric Blake
2019-01-12 17:58 ` [Qemu-devel] [PATCH v3 16/19] nbd/client: Add meta contexts to nbd_receive_export_list() Eric Blake
2019-01-16 10:54 ` Vladimir Sementsov-Ogievskiy
2019-01-12 17:58 ` [Qemu-devel] [PATCH v3 17/19] qemu-nbd: Add --list option Eric Blake
2019-01-17 10:05 ` Vladimir Sementsov-Ogievskiy
2019-01-17 16:58 ` Eric Blake
2019-01-17 17:11 ` Vladimir Sementsov-Ogievskiy
2019-01-12 17:58 ` [Qemu-devel] [PATCH v3 18/19] nbd/client: Work around 3.0 bug for listing meta contexts Eric Blake
2019-01-16 15:43 ` Vladimir Sementsov-Ogievskiy
2019-01-17 3:21 ` Eric Blake
2019-01-17 8:07 ` Vladimir Sementsov-Ogievskiy
2019-01-17 14:20 ` Eric Blake
2019-01-12 17:58 ` [Qemu-devel] [PATCH v3 19/19] iotests: Enhance 223, 233 to cover 'qemu-nbd --list' Eric Blake
2019-01-17 13:34 ` Eric Blake
2019-01-14 12:22 ` [Qemu-devel] [PATCH v3 00/19] nbd: add qemu-nbd --list Vladimir Sementsov-Ogievskiy
2019-01-14 16:46 ` Eric Blake
2019-01-17 11:38 ` Vladimir Sementsov-Ogievskiy
2019-01-17 14:20 ` Eric Blake
2019-01-23 12:36 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be13579b-6007-a6f4-3e04-f54d01033cb5@redhat.com \
--to=eblake@redhat.com \
--cc=jsnow@redhat.com \
--cc=nsoffer@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rjones@redhat.com \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).