From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33721) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1evhcS-0008CS-Uy for qemu-devel@nongnu.org; Tue, 13 Mar 2018 06:57:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1evhcO-0007wt-1G for qemu-devel@nongnu.org; Tue, 13 Mar 2018 06:57:25 -0400 Received: from mail-wr0-f175.google.com ([209.85.128.175]:38526) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1evhcN-0007vz-QD for qemu-devel@nongnu.org; Tue, 13 Mar 2018 06:57:19 -0400 Received: by mail-wr0-f175.google.com with SMTP id l8so6954865wrg.5 for ; Tue, 13 Mar 2018 03:57:19 -0700 (PDT) References: <20180312141714.7223-1-berrange@redhat.com> <20180313092053.GA3545@work-vm> From: Paolo Bonzini Message-ID: Date: Tue, 13 Mar 2018 11:57:17 +0100 MIME-Version: 1.0 In-Reply-To: <20180313092053.GA3545@work-vm> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.12 REPOST] migration: convert socket server to QIONetListener List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert" , "=?UTF-8?Q?Daniel_P._Berrang=c3=a9?=" Cc: qemu-devel@nongnu.org, Juan Quintela On 13/03/2018 10:20, Dr. David Alan Gilbert wrote: >> static void socket_start_incoming_migration(SocketAddress *saddr, >> Error **errp) >> { >> - QIOChannelSocket *listen_ioc = qio_channel_socket_new(); >> + QIONetListener *listener = qio_net_listener_new(); >> >> - qio_channel_set_name(QIO_CHANNEL(listen_ioc), >> - "migration-socket-listener"); >> + qio_net_listener_set_name(listener, "migration-socket-listener"); >> >> - if (qio_channel_socket_listen_sync(listen_ioc, saddr, errp) < 0) { >> - object_unref(OBJECT(listen_ioc)); >> + if (qio_net_listener_open_sync(listener, saddr, errp) < 0) { >> + object_unref(OBJECT(listener)); >> return; >> } >> >> - qio_channel_add_watch(QIO_CHANNEL(listen_ioc), >> - G_IO_IN, >> - socket_accept_incoming_migration, >> - listen_ioc, >> - (GDestroyNotify)object_unref); >> + qio_net_listener_set_client_func(listener, >> + socket_accept_incoming_migration, >> + NULL, NULL); >> } >> >> void tcp_start_incoming_migration(const char *host_port, Error **errp) >> -- >> 2.14.3 >> > -- > Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK > Could this get in 2.12 as a bugfix, even after soft freeze? It's the last user of qio_channel_listen_sync that blocks full IPv4/IPv6 support. All other users are for vsock/AF_UNIX. Paolo