From: Richard Henderson <richard.henderson@linaro.org>
To: "Thomas Huth" <thuth@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
qemu-devel@nongnu.org
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
qemu-trivial@nongnu.org
Subject: Re: [PATCH v2] meson.build: Use -Wno-undef only for SDL2 versions that need it
Date: Fri, 2 Jun 2023 20:30:58 -0700 [thread overview]
Message-ID: <be1cae90-8acb-7185-7bdf-24d3348bf251@linaro.org> (raw)
In-Reply-To: <20230602163452.521305-1-thuth@redhat.com>
On 6/2/23 09:34, Thomas Huth wrote:
> There is no need to disable this useful compiler warning for
> all versions of the SDL. Unfortunately, various versions are
> buggy (beside SDL 2.0.8, the version 2.26.0 and 2.26.1 are
> broken, too, seehttps://github.com/libsdl-org/SDL/issues/6619 ),
> but we can use a simple compiler check to see whether we need
> the -Wno-undef or not.
>
> This also enables the printing of the version number with
> good versions of the SDL in the summary of the meson output
> again.
>
> Signed-off-by: Thomas Huth<thuth@redhat.com>
> ---
> v2: Compile test code instead of hard-coding the version number
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2023-06-03 3:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-02 16:34 [PATCH v2] meson.build: Use -Wno-undef only for SDL2 versions that need it Thomas Huth
2023-06-03 3:30 ` Richard Henderson [this message]
2023-06-05 7:46 ` Thomas Huth
2023-06-05 8:27 ` Paolo Bonzini
2023-06-05 8:47 ` Thomas Huth
2023-06-05 9:05 ` Paolo Bonzini
2023-06-05 9:48 ` Paolo Bonzini
2023-06-05 8:53 ` Daniel P. Berrangé
2023-06-05 8:58 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be1cae90-8acb-7185-7bdf-24d3348bf251@linaro.org \
--to=richard.henderson@linaro.org \
--cc=berrange@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).