From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E986CC7EE2A for ; Sat, 3 Jun 2023 03:31:23 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q5Hyr-0008Vm-B9; Fri, 02 Jun 2023 23:31:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q5Hyp-0008V0-Sq for qemu-devel@nongnu.org; Fri, 02 Jun 2023 23:31:03 -0400 Received: from mail-pg1-x52e.google.com ([2607:f8b0:4864:20::52e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q5Hyo-0005Bw-3t for qemu-devel@nongnu.org; Fri, 02 Jun 2023 23:31:03 -0400 Received: by mail-pg1-x52e.google.com with SMTP id 41be03b00d2f7-5289ce6be53so3010524a12.0 for ; Fri, 02 Jun 2023 20:31:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1685763060; x=1688355060; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=fVO11osr2WstJ75ZO8yVWXRosy8XF2DV4DFhAwaowtk=; b=hhMUyeYDR9U25LLNNDg5ZfgRnNbQEh3JKeak0trWbkEL21dFq52Jp4UethT3D8H1Kg xQ1qZulb+Ymozu0I9kRrw6nt3DnfLXIOBBu8NBOYaowAVHcoRbxBff5qws56YK7wqhxT RUj14vX5KmIKz2nuSwrOU1iEXnJUq1v7x2tWoud9MQj++jPl4ZfMz302LxmxWM3KSzvw rpfN+xM69UyOIueZVM6rRrFZDoC55FgF8d4iorJCpqPgF4yqEF5kIvvUtTMG4wr33GSs gvdZTV2KMjO1fHj075Vv/I/85PGfAd9631xEgA9cjCWrud8ilaYWCBwdMf5Wkwjg5cgT OjQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685763060; x=1688355060; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fVO11osr2WstJ75ZO8yVWXRosy8XF2DV4DFhAwaowtk=; b=KJnQJVjNvjHFlp6yJjLVztxKRVGKVZIftxaut3JW5V192DxjKX/LHHPPvWfCmRT5fY pt1hiN8vsECydCE8Kq0IudVLelgnkZMqXivUyO8ggicA3uhOTrIKDmXa7iDzkcnK4V79 lYZwn2AfcBc6rVjJvLBqigiXYHH8JX/H99+VFmOy672//PZiYU26o0eneUp3zxZ4UQqm 9Nbf9XzzaCVxkNGcwi65pNCzn218CQhAx7WDLgT4Bp/4TmQPjRaeKGvY7C7Vb0N9Kpcg hLPJNTOM9+hA5gId8rdEANc4VQ84Lbw5SUUvgDMuowA7pH5fnqN2O1358ecOboxog3DH +/Lg== X-Gm-Message-State: AC+VfDzBNsubRiyPaCaD19VTNDTsNym6WXnF4Vaw94BYoPLB1npRF9Yx H8+SPWxwDjMygKACj/sDuJgD0Q== X-Google-Smtp-Source: ACHHUZ6nVbCfXb18EWNOGHmYh+FhY4nKH4zHB4OsdJfpgorbeWBsKWOBZzN59JQ4SNtzODTA388b+g== X-Received: by 2002:a17:902:9887:b0:1a9:80a0:47ef with SMTP id s7-20020a170902988700b001a980a047efmr1288661plp.20.1685763060277; Fri, 02 Jun 2023 20:31:00 -0700 (PDT) Received: from ?IPV6:2602:ae:1598:4c01:66a6:82c2:d794:68f6? ([2602:ae:1598:4c01:66a6:82c2:d794:68f6]) by smtp.gmail.com with ESMTPSA id b6-20020a170903228600b001a9873495f2sm2070283plh.233.2023.06.02.20.30.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Jun 2023 20:30:59 -0700 (PDT) Message-ID: Date: Fri, 2 Jun 2023 20:30:58 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v2] meson.build: Use -Wno-undef only for SDL2 versions that need it Content-Language: en-US To: Thomas Huth , Paolo Bonzini , =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , qemu-devel@nongnu.org Cc: =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-trivial@nongnu.org References: <20230602163452.521305-1-thuth@redhat.com> From: Richard Henderson In-Reply-To: <20230602163452.521305-1-thuth@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::52e; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x52e.google.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.095, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 6/2/23 09:34, Thomas Huth wrote: > There is no need to disable this useful compiler warning for > all versions of the SDL. Unfortunately, various versions are > buggy (beside SDL 2.0.8, the version 2.26.0 and 2.26.1 are > broken, too, seehttps://github.com/libsdl-org/SDL/issues/6619 ), > but we can use a simple compiler check to see whether we need > the -Wno-undef or not. > > This also enables the printing of the version number with > good versions of the SDL in the summary of the meson output > again. > > Signed-off-by: Thomas Huth > --- > v2: Compile test code instead of hard-coding the version number Reviewed-by: Richard Henderson r~