Re: [PATCH v3] escc: convert Sun mouse to use QemuInputHandler

["Philippe Mathieu-Daudé" <philmd@linaro.org>]

On 6/9/24 22:55, Mark Cave-Ayland wrote:
> On 04/09/2024 12:19, Mark Cave-Ayland wrote:
> 
>> On 04/09/2024 11:53, Philippe Mathieu-Daudé wrote:
>>
>>> On 4/9/24 12:23, Mark Cave-Ayland wrote:
>>>> Update the Sun mouse implementation to use QemuInputHandler instead 
>>>> of the
>>>> legacy qemu_add_mouse_event_handler() function.
>>>>
>>>> Note that this conversion adds extra sunmouse_* members to 
>>>> ESCCChannelState
>>>> but they are not added to the migration stream (similar to the Sun 
>>>> keyboard
>>>> members). If this were desired in future, the Sun devices should be 
>>>> split
>>>> into separate devices and added to the migration stream there instead.
>>>>
>>>> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
>>>> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2518
>>>> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
>>>
>>> On v3 there is also an implicit:
>>> Tested-by: Carl Hauser <chauser@pullman.com>
>>
>> That's true, although I'm hesitant to add such a tag without a nod 
>> from the tester. Carl, are you happy for me to add your Tested-by tag 
>> upon merge?
> 
> I've received confirmation off-list that Carl is happy with the above 
> tag, so we're good to add it to the final merged version. Phil, are you 
> able to queue this in your next PR or would you prefer me to send a 
> separate PR instead?

Patch queued, thanks!

>>>> ---
>>>>   hw/char/escc.c         | 88 
>>>> +++++++++++++++++++++++++++++++-----------
>>>>   include/hw/char/escc.h |  3 ++
>>>>   2 files changed, 69 insertions(+), 22 deletions(-)