From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39969) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c3fyG-00044F-BV for qemu-devel@nongnu.org; Mon, 07 Nov 2016 04:12:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c3fyB-0000Oz-8q for qemu-devel@nongnu.org; Mon, 07 Nov 2016 04:12:04 -0500 References: <1478257275-30365-1-git-send-email-mst@redhat.com> <1478257275-30365-3-git-send-email-mst@redhat.com> From: Jason Wang Message-ID: Date: Mon, 7 Nov 2016 17:11:54 +0800 MIME-Version: 1.0 In-Reply-To: <1478257275-30365-3-git-send-email-mst@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 2/2] virtio-net: mark VIRTIO_NET_F_GSO as legacy List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , qemu-devel@nongnu.org Cc: dgilbert@redhat.com, qemu-stable@nongnu.org On 2016=E5=B9=B411=E6=9C=8804=E6=97=A5 19:01, Michael S. Tsirkin wrote: > virtio 1.0 spec says this is a legacy feature bit, > hide it from guests in legacy mode. > > Note: for cross-version migration compatibility, > we keep the bit set in host_features. > The result will be that a guest migrating cross-version > will see host features change under it. > As guests only seem to read it once, this should > not be an issue. Meanwhile, will work to fix guests to > ignore this bit in virtio1 mode, too. > > Cc: qemu-stable@nongnu.org > Signed-off-by: Michael S. Tsirkin > --- > hw/net/virtio-net.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c > index 20aa63e..b68c69d 100644 > --- a/hw/net/virtio-net.c > +++ b/hw/net/virtio-net.c > @@ -1942,6 +1942,7 @@ static void virtio_net_class_init(ObjectClass *kl= ass, void *data) > vdc->guest_notifier_pending =3D virtio_net_guest_notifier_pending= ; > vdc->load =3D virtio_net_load_device; > vdc->save =3D virtio_net_save_device; > + vdc->legacy_features |=3D (0x1 << VIRTIO_NET_F_GSO); > } > =20 > static const TypeInfo virtio_net_info =3D { Acked-by: Jason Wang