Re: [Qemu-devel] [PATCH v2 03/22] maint: Allow for EXAMPLES in texi2pod

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 2148 bytes --]

On 1/4/19 5:45 PM, Eric Blake wrote:
> On 12/18/18 7:46 AM, Vladimir Sementsov-Ogievskiy wrote:
>> 15.12.2018 16:53, Eric Blake wrote:
>>> The next commit will add an EXAMPLES section to qemu-nbd.8;
>>> for that to work, we need to recognize EXAMPLES in texi2pod,
>>> and we need to make all man pages be regenerated since the
>>> output of texi2pod can be different.
>>>
>>> Signed-off-by: Eric Blake <eblake@redhat.com>
>>>
> 
>>> +qemu.1: qemu-doc.texi qemu-options.texi qemu-monitor.texi \
>>> +	qemu-monitor-info.texi scripts/texi2pod.pl
>>> +qemu.1: qemu-option-trace.texi scripts/texi2pod.pl
>>
>> I think, no needs to add scripts/texi2pod.pl to both qemu.1: lines, as they should be
>> merged anyway. And if you want to add line breaking anyway, it looks better to use one qemu.1:
>> dependency line.
> 
> Easy to fix.
> 
>>
>> On the other hand, it may be better to add MANS variable as subset of DOCS to combine all man page targets,
>> and than do like $(MANS): scripts/texi2pod.pl.. (and recombine DOCS, using MANS ofcourse)

Even easier (although it took me a while digging through 'info man' to
learn it):

$(filter %.1 %.7 %.8,$(DOCS)): scripts/texi2pod.pl

although the dependency must be listed AFTER any more specific rule
(since rules.mak has a %.1: pattern rule which expands $< to the first
dependency, and we do not want scripts/texi2pod.pl to be treated as our
first dependency).

>> Hm, and I don't see here docs/interop/qemu-ga-ref.7 and docs/interop/qemu-qmp-ref.7,
>> which exist in DOCS.

They are there, just harder to see (hence why my v2 missed them). Of
course, doing the generic dependency is better than editing every single
man file listing.

> 
> Oh, good point. The .txt files should also have the dependency

Or not. The .txt output files depend on the .texi source, not on the
generated .1 page; only the files that used scripts/texi2pod.pl need to
depend on that, and based on rules.mk, that is only the 3 man page
categories.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]