qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: David Edmondson <dme@dme.org>, Eric Blake <eblake@redhat.com>,
	qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
	"open list:Block layer core" <qemu-block@nongnu.org>,
	crosthwaite.peter@gmail.com, quintela@redhat.com,
	dgilbert@redhat.com, Max Reitz <mreitz@redhat.com>,
	kraxel@redhat.com, dirty.ice.hu@gmail.com, pbonzini@redhat.com,
	rth@twiddle.net
Subject: Re: [PATCH v4] osdep: Make MIN/MAX evaluate arguments only once
Date: Fri, 5 Jun 2020 10:54:09 +0200	[thread overview]
Message-ID: <be4d75b5-b545-0802-cbe7-0bb8d352d6b2@redhat.com> (raw)
In-Reply-To: <m2eeqtapix.fsf@dme.org>

On 6/5/20 10:24 AM, David Edmondson wrote:
> On Thursday, 2020-06-04 at 16:52:36 -05, Eric Blake wrote:
> 
>>  /* Minimum function that returns zero only iff both values are zero.
> 
> Not your change, but "only" is unnecessary here (or iff -> if).

Maybe we should teach checkpatch.pl to refuse the idiomatic 'iff',
it is already hard enough for non-native English to read (or write)
technical documentation...



  reply	other threads:[~2020-06-05  8:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-04 21:52 [PATCH v4] osdep: Make MIN/MAX evaluate arguments only once Eric Blake
2020-06-04 21:55 ` Eric Blake
2020-06-04 22:28 ` Richard Henderson
2020-06-05  8:24 ` David Edmondson
2020-06-05  8:54   ` Philippe Mathieu-Daudé [this message]
2020-06-05 14:03   ` Eric Blake
2020-06-23  9:31 ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=be4d75b5-b545-0802-cbe7-0bb8d352d6b2@redhat.com \
    --to=philmd@redhat.com \
    --cc=crosthwaite.peter@gmail.com \
    --cc=dgilbert@redhat.com \
    --cc=dirty.ice.hu@gmail.com \
    --cc=dme@dme.org \
    --cc=eblake@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).