Re: [PATCH 1/2] tests/vm: skip X11 in openbsd installation

[Thomas Huth <thuth@redhat.com>]

On 22/03/2023 16.20, Brad Smith wrote:
> On 2023-03-22 9:40 a.m., Thomas Huth wrote:
>> On 22/03/2023 14.38, Philippe Mathieu-Daudé wrote:
>>> On 22/3/23 13:36, Daniel P. Berrangé wrote:
>>>> As a VM used only for automated testing there is no need to
>>>> install the X11 stack.
>>>>
>>>> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
>>>> ---
>>>>   tests/vm/openbsd | 3 +--
>>>>   1 file changed, 1 insertion(+), 2 deletions(-)
>>>>
>>>> diff --git a/tests/vm/openbsd b/tests/vm/openbsd
>>>> index eaeb201e91..6af7afac0d 100755
>>>> --- a/tests/vm/openbsd
>>>> +++ b/tests/vm/openbsd
>>>> @@ -106,8 +106,7 @@ class OpenBSDVM(basevm.BaseVM):
>>>>           self.console_wait("Password for root account")
>>>>           self.console_send("%s\n" % self._config["root_pass"])
>>>>           self.console_wait_send("Start sshd(8)", "yes\n")
>>>> -        self.console_wait_send("X Window System", "\n")
>>>> -        self.console_wait_send("xenodm", "\n")
>>>> +        self.console_wait_send("X Window System", "no\n")
>>>
>>> Wasn't this useful to link a X11-ready binary, even if only testing
>>> with -display=none?
>>
>> tests/vm/openbsd later installs sdl2 and gtk+3, so I assume that will pull 
>> in the required libraries if necessary, without all the other 
>> non-necessary stuff.
> 
> No, it will not. If you want sdl2 / gtk+3 you have to have X enabled.

I meant for compiling, not for running QEMU... and we're only running in 
non-graphical mode here later, so I hope that should be fine.

  Thomas