Re: [Qemu-devel] [PATCH v3 32/36] ssh: Support .bdrv_co_create

[Max Reitz <mreitz@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 733 bytes --]

On 2018-02-23 20:25, Kevin Wolf wrote:
> This adds the .bdrv_co_create driver callback to ssh, which enables
> image creation over QMP.
> 
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> Reviewed-by: Max Reitz <mreitz@redhat.com>
> ---
>  qapi/block-core.json | 16 ++++++++-
>  block/ssh.c          | 92 +++++++++++++++++++++++++++++-----------------------
>  2 files changed, 67 insertions(+), 41 deletions(-)

As written just now in my reply to v2 (clever me), this conflicts with
my patches to add truncation support to ssh -- and since your series
requires protocols to have feature parity when comparing truncation on
creation and truncation on-the-fly, I insolently claim that you should
rebase. O:-)

Max


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 512 bytes --]