From: Eric Blake <eblake@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-devel@nongnu.org
Cc: den@openvz.org, berrange@redhat.com, armbru@redhat.com,
kraxel@redhat.com
Subject: Re: [Qemu-devel] [PATCH v4] qapi: Add InetSocketAddress member keep-alive
Date: Mon, 29 Jul 2019 15:51:28 -0500 [thread overview]
Message-ID: <be68ad00-425d-efbd-0dda-a1cd8d4652fc@redhat.com> (raw)
In-Reply-To: <20190725094937.32454-1-vsementsov@virtuozzo.com>
[-- Attachment #1.1: Type: text/plain, Size: 693 bytes --]
On 7/25/19 4:49 AM, Vladimir Sementsov-Ogievskiy wrote:
> It's needed to provide keepalive for nbd client to track server
> availability.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
> +++ b/util/qemu-sockets.c
> @@ -219,6 +219,12 @@ static int inet_listen_saddr(InetSocketAddress *saddr,
> bool socket_created = false;
> Error *err = NULL;
>
> + if (saddr->keep_alive) {
> + error_setg(errp, "keep-alive options is not supported for passive "
option
(will fix as part of staging)
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2019-07-29 20:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-25 9:49 [Qemu-devel] [PATCH v4] qapi: Add InetSocketAddress member keep-alive Vladimir Sementsov-Ogievskiy
2019-07-25 15:26 ` Markus Armbruster
2019-07-25 16:38 ` Eric Blake
2019-07-25 16:50 ` Daniel P. Berrangé
2019-07-25 19:59 ` Markus Armbruster
2019-07-29 20:51 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be68ad00-425d-efbd-0dda-a1cd8d4652fc@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=den@openvz.org \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).