From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
Cameron Esfahani <dirty@apple.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Eduardo Habkost <eduardo@habkost.net>,
haxm-team@intel.com, Roman Bolshakov <r.bolshakov@yadro.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Wenchao Wang <wenchao.wang@intel.com>
Subject: Re: [PATCH 4/5] target/i386: Remove x86_cpu_dump_local_apic_state() dead stub
Date: Fri, 16 Dec 2022 16:24:40 -0800 [thread overview]
Message-ID: <be73766d-2848-0a23-94d3-f8a87562a36a@linaro.org> (raw)
In-Reply-To: <20221216220158.6317-5-philmd@linaro.org>
On 12/16/22 14:01, Philippe Mathieu-Daudé wrote:
> x86_cpu_dump_local_apic_state() is called from monitor.c which
> is only compiled for system emulation since commit bf95728400
> ("monitor: remove target-specific code from monitor.c").
>
> Interestingly this stub was added few weeks later in commit
> 1f871d49e3 ("hmp: added local apic dump state") and was not
> necessary by that time.
Crossed in-flight, presumably.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2022-12-17 0:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-16 22:01 [PATCH 0/5] target/i386: Header cleanups around "cpu.h" Philippe Mathieu-Daudé
2022-12-16 22:01 ` [PATCH 1/5] target/i386: Remove NEED_CPU_H guard from target-specific headers Philippe Mathieu-Daudé
2022-12-17 0:21 ` Richard Henderson
2022-12-16 22:01 ` [PATCH 2/5] target/i386/cpu: Remove dead helper_lock() declaration Philippe Mathieu-Daudé
2022-12-17 0:21 ` Richard Henderson
2022-12-16 22:01 ` [PATCH 3/5] target/i386/ops_sse: Include missing "cpu.h" header Philippe Mathieu-Daudé
2022-12-17 0:23 ` Richard Henderson
2022-12-16 22:01 ` [PATCH 4/5] target/i386: Remove x86_cpu_dump_local_apic_state() dead stub Philippe Mathieu-Daudé
2022-12-17 0:24 ` Richard Henderson [this message]
2022-12-16 22:01 ` [PATCH 5/5] hw/i386/x86: Reduce init_topo_info() scope Philippe Mathieu-Daudé
2022-12-17 0:25 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be73766d-2848-0a23-94d3-f8a87562a36a@linaro.org \
--to=richard.henderson@linaro.org \
--cc=dirty@apple.com \
--cc=eduardo@habkost.net \
--cc=haxm-team@intel.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=r.bolshakov@yadro.com \
--cc=wenchao.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).