* [PATCH] tb-maint: Document #ifdef..else..endif correctly
@ 2023-07-06 13:43 Richard W.M. Jones
2023-07-06 16:52 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 2+ messages in thread
From: Richard W.M. Jones @ 2023-07-06 13:43 UTC (permalink / raw)
To: richard.henderson; +Cc: pbonzini, qemu-devel
It was hard to tell from the comments whether the code applied to user
mode (CONFIG_USER_ONLY) or system mode. Fix the comments on the #else
and #endif directives to be clearer.
Signed-off-by: Richard W.M. Jones <rjones@redhat.com>
---
accel/tcg/tb-maint.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/accel/tcg/tb-maint.c b/accel/tcg/tb-maint.c
index 9566224d18..bf99a46872 100644
--- a/accel/tcg/tb-maint.c
+++ b/accel/tcg/tb-maint.c
@@ -156,7 +156,7 @@ static PageForEachNext foreach_tb_next(PageForEachNext tb,
return NULL;
}
-#else
+#else /* !CONFIG_USER_ONLY */
/*
* In system mode we want L1_MAP to be based on ram offsets.
*/
@@ -722,7 +722,7 @@ static void page_unlock_tb(const TranslationBlock *tb)
}
}
}
-#endif /* CONFIG_USER_ONLY */
+#endif /* !CONFIG_USER_ONLY */
/* flush all the translation blocks */
static void do_tb_flush(CPUState *cpu, run_on_cpu_data tb_flush_count)
--
2.41.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] tb-maint: Document #ifdef..else..endif correctly
2023-07-06 13:43 [PATCH] tb-maint: Document #ifdef..else..endif correctly Richard W.M. Jones
@ 2023-07-06 16:52 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-07-06 16:52 UTC (permalink / raw)
To: Richard W.M. Jones, richard.henderson; +Cc: pbonzini, qemu-devel
On 6/7/23 15:43, Richard W.M. Jones wrote:
> It was hard to tell from the comments whether the code applied to user
> mode (CONFIG_USER_ONLY) or system mode. Fix the comments on the #else
> and #endif directives to be clearer.
>
> Signed-off-by: Richard W.M. Jones <rjones@redhat.com>
> ---
> accel/tcg/tb-maint.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-06 16:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-06 13:43 [PATCH] tb-maint: Document #ifdef..else..endif correctly Richard W.M. Jones
2023-07-06 16:52 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).