From: Pierrick Bouvier <pierrick.bouvier@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: Pavel Pisa <pisa@cmp.felk.cvut.cz>,
Francisco Iglesias <francisco.iglesias@amd.com>,
Jason Wang <jasowang@redhat.com>
Subject: Re: [RFC PATCH] hw/net/can: clean-up unnecessary includes
Date: Mon, 9 Dec 2024 10:58:07 -0800 [thread overview]
Message-ID: <be877e3b-837c-402a-8d00-2e5ca8033c9c@linaro.org> (raw)
In-Reply-To: <20241209100635.93243-1-alex.bennee@linaro.org>
On 12/9/24 02:06, Alex Bennée wrote:
> The event_notifier, thread and socket includes look like copy and
> paste of standard headers. None of the canbus devices use chardev
> although some relied on chardev to bring in bitops and byte swapping
> headers. In this case include them directly.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> hw/net/can/can_kvaser_pci.c | 4 ----
> hw/net/can/can_mioe3680_pci.c | 4 ----
> hw/net/can/can_pcm3680_pci.c | 4 ----
> hw/net/can/can_sja1000.c | 2 +-
> hw/net/can/ctucan_core.c | 3 ++-
> hw/net/can/ctucan_pci.c | 4 ----
> 6 files changed, 3 insertions(+), 18 deletions(-)
>
> diff --git a/hw/net/can/can_kvaser_pci.c b/hw/net/can/can_kvaser_pci.c
> index 38434d3a04..9e363d532f 100644
> --- a/hw/net/can/can_kvaser_pci.c
> +++ b/hw/net/can/can_kvaser_pci.c
> @@ -30,12 +30,8 @@
> */
>
> #include "qemu/osdep.h"
> -#include "qemu/event_notifier.h"
> #include "qemu/module.h"
> -#include "qemu/thread.h"
> -#include "qemu/sockets.h"
> #include "qapi/error.h"
> -#include "chardev/char.h"
> #include "hw/irq.h"
> #include "hw/pci/pci_device.h"
> #include "hw/qdev-properties.h"
> diff --git a/hw/net/can/can_mioe3680_pci.c b/hw/net/can/can_mioe3680_pci.c
> index 21659b7afb..580f099e00 100644
> --- a/hw/net/can/can_mioe3680_pci.c
> +++ b/hw/net/can/can_mioe3680_pci.c
> @@ -26,12 +26,8 @@
> */
>
> #include "qemu/osdep.h"
> -#include "qemu/event_notifier.h"
> #include "qemu/module.h"
> -#include "qemu/thread.h"
> -#include "qemu/sockets.h"
> #include "qapi/error.h"
> -#include "chardev/char.h"
> #include "hw/irq.h"
> #include "hw/pci/pci_device.h"
> #include "hw/qdev-properties.h"
> diff --git a/hw/net/can/can_pcm3680_pci.c b/hw/net/can/can_pcm3680_pci.c
> index af21dc6855..3195b79954 100644
> --- a/hw/net/can/can_pcm3680_pci.c
> +++ b/hw/net/can/can_pcm3680_pci.c
> @@ -26,12 +26,8 @@
> */
>
> #include "qemu/osdep.h"
> -#include "qemu/event_notifier.h"
> #include "qemu/module.h"
> -#include "qemu/thread.h"
> -#include "qemu/sockets.h"
> #include "qapi/error.h"
> -#include "chardev/char.h"
> #include "hw/irq.h"
> #include "hw/pci/pci_device.h"
> #include "hw/qdev-properties.h"
> diff --git a/hw/net/can/can_sja1000.c b/hw/net/can/can_sja1000.c
> index 6694d7bfd8..5b6ba9df6c 100644
> --- a/hw/net/can/can_sja1000.c
> +++ b/hw/net/can/can_sja1000.c
> @@ -27,7 +27,7 @@
>
> #include "qemu/osdep.h"
> #include "qemu/log.h"
> -#include "chardev/char.h"
> +#include "qemu/bitops.h"
> #include "hw/irq.h"
> #include "migration/vmstate.h"
> #include "net/can_emu.h"
> diff --git a/hw/net/can/ctucan_core.c b/hw/net/can/ctucan_core.c
> index 812b83e93e..4402d4cb1f 100644
> --- a/hw/net/can/ctucan_core.c
> +++ b/hw/net/can/ctucan_core.c
> @@ -28,7 +28,8 @@
>
> #include "qemu/osdep.h"
> #include "qemu/log.h"
> -#include "chardev/char.h"
> +#include "qemu/bswap.h"
> +#include "qemu/bitops.h"
> #include "hw/irq.h"
> #include "migration/vmstate.h"
> #include "net/can_emu.h"
> diff --git a/hw/net/can/ctucan_pci.c b/hw/net/can/ctucan_pci.c
> index 65f1f82303..a8c77b9194 100644
> --- a/hw/net/can/ctucan_pci.c
> +++ b/hw/net/can/ctucan_pci.c
> @@ -27,12 +27,8 @@
> */
>
> #include "qemu/osdep.h"
> -#include "qemu/event_notifier.h"
> #include "qemu/module.h"
> -#include "qemu/thread.h"
> -#include "qemu/sockets.h"
> #include "qapi/error.h"
> -#include "chardev/char.h"
> #include "hw/irq.h"
> #include "hw/pci/pci_device.h"
> #include "hw/qdev-properties.h"
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
prev parent reply other threads:[~2024-12-09 18:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-09 10:06 [RFC PATCH] hw/net/can: clean-up unnecessary includes Alex Bennée
2024-12-09 11:23 ` Pavel Pisa
2024-12-09 16:22 ` Philippe Mathieu-Daudé
2024-12-09 18:58 ` Pierrick Bouvier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be877e3b-837c-402a-8d00-2e5ca8033c9c@linaro.org \
--to=pierrick.bouvier@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=francisco.iglesias@amd.com \
--cc=jasowang@redhat.com \
--cc=pisa@cmp.felk.cvut.cz \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).