From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: BALATON Zoltan <balaton@eik.bme.hu>,
Paolo Bonzini <pbonzini@redhat.com>,
qemu-block@nongnu.org, Bernhard Beschow <shentey@gmail.com>,
Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
John Snow <jsnow@redhat.com>, Eric Blake <eblake@redhat.com>
Subject: Re: [PATCH 6/7] hw/isa: Assert isa_register_portio_list() gets non-NULL ISA device
Date: Tue, 14 Feb 2023 08:49:40 -1000 [thread overview]
Message-ID: <be88dc7c-750f-f4a3-c350-d780e36337ae@linaro.org> (raw)
In-Reply-To: <f088930b-ad9d-354d-5053-f319272140a1@linaro.org>
On 2/14/23 00:18, Philippe Mathieu-Daudé wrote:
> __attribute__((nonnull)) void a1(void *ptr)
> {
> // can no use assert(ptr) because compiler warning
> }
I briefly glossed over that...
>> I realize we'd probably want to add -fno-delete-null-pointer-checks if we make too much
... here. The compiler warning should go away with the right flag.
r~
next prev parent reply other threads:[~2023-02-14 18:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-08 0:07 [PATCH 0/7] hw/ide: Untangle ISA/PCI abuses of ide_init_ioport() Philippe Mathieu-Daudé
2023-02-08 0:07 ` [PATCH 1/7] hw/isa: Un-inline isa_bus_from_device() Philippe Mathieu-Daudé
2023-02-08 0:07 ` [PATCH 2/7] hw/isa: Use isa_address_space_io() to reduce access on global 'isabus' Philippe Mathieu-Daudé
2023-02-08 0:07 ` [PATCH 3/7] hw/ide: Rename ISA specific ide_init_ioport() as ide_init_ioport_isa() Philippe Mathieu-Daudé
2023-02-08 0:07 ` [PATCH 4/7] hw/ide: Introduce generic ide_init_ioport() Philippe Mathieu-Daudé
2023-02-08 0:07 ` [PATCH 5/7] hw/ide/piix: Use " Philippe Mathieu-Daudé
2023-02-09 9:04 ` Bernhard Beschow
2023-02-10 16:34 ` Bernhard Beschow
2023-02-15 20:59 ` Philippe Mathieu-Daudé
2023-03-01 12:14 ` Mark Cave-Ayland
2023-02-08 0:07 ` [PATCH 6/7] hw/isa: Assert isa_register_portio_list() gets non-NULL ISA device Philippe Mathieu-Daudé
[not found] ` <8bcc1035-c9fc-762a-7a32-6b0344539345@linaro.org>
2023-02-14 10:18 ` Philippe Mathieu-Daudé
2023-02-14 18:49 ` Richard Henderson [this message]
2023-02-15 7:12 ` Philippe Mathieu-Daudé
2023-02-08 0:07 ` [PATCH 7/7] hw/ide/piix: Remove dead code in pci_piix_init_ports() Philippe Mathieu-Daudé
2023-02-08 19:40 ` Richard Henderson
2023-02-08 0:09 ` [PATCH 0/7] hw/ide: Untangle ISA/PCI abuses of ide_init_ioport() Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be88dc7c-750f-f4a3-c350-d780e36337ae@linaro.org \
--to=richard.henderson@linaro.org \
--cc=balaton@eik.bme.hu \
--cc=eblake@redhat.com \
--cc=jsnow@redhat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=shentey@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).