Re: [PATCH] ci: build out-of-tree

[Thomas Huth <thuth@redhat.com>]

On 11/12/2019 15.30, Paolo Bonzini wrote:
> Most developers are using out-of-tree builds and it was discussed in the past
> to only allow those.  To prepare for the transition, use out-of-tree builds
> in all continuous integration jobs.
> 
> Based on a patch by Marc-André Lureau.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
[...]
> diff --git a/.travis.yml b/.travis.yml
> index 445b064..d259b51 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -74,8 +74,8 @@ notifications:
>  
>  env:
>    global:
> -    - SRC_DIR="."
> -    - BUILD_DIR="."
> +    - SRC_DIR=".."
> +    - BUILD_DIR="build"
>      - BASE_CONFIG="--disable-docs --disable-tools"
>      - TEST_CMD="make check V=1"
>      # This is broadly a list of "mainline" softmmu targets which have support across the major distros
> @@ -192,7 +192,9 @@ matrix:
>          - CACHE_NAME="${TRAVIS_BRANCH}-linux-clang-sanitize"
>        compiler: clang
>        before_script:
> +        - mkdir -p ${BUILD_DIR} && cd ${BUILD_DIR}
>          - ./configure ${CONFIG} --extra-cflags="-fsanitize=undefined -Werror" || { cat config.log && exit 1; }

Don't you want to remove the old line?

> +        - ${SRC_DIR}/configure ${CONFIG} --extra-cflags="-fsanitize=undefined -Werror" --extra-ldflags="-fsanitize=undefined" || { cat config.log && exit 1; }
>  
>  
>      - env:
> @@ -323,6 +325,7 @@ matrix:
>          - CONFIG="--cc=gcc-9 --cxx=g++-9 --disable-pie --disable-linux-user"
>          - TEST_CMD=""
>        before_script:
> +        - mkdir -p ${BUILD_DIR} && cd ${BUILD_DIR}
>          - ./configure ${CONFIG} --extra-cflags="-g3 -O0 -Wno-error=stringop-truncation -fsanitize=thread -fuse-ld=gold" || { cat config.log && exit 1; }

That should also use "../configure" (or $SRC_DIR/configure), shouldn't it?

 Thomas