qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
	Samuel Thibault <samuel.thibault@ens-lyon.org>
Subject: Re: [Qemu-devel] [PATCH] slirp: add tftp tracing
Date: Tue, 13 Nov 2018 13:38:01 +0100	[thread overview]
Message-ID: <bea636d4-9f0c-de1f-ac70-3ce4a2245033@redhat.com> (raw)
In-Reply-To: <20181113070320.16147-1-kraxel@redhat.com>

On 13/11/18 8:03, Gerd Hoffmann wrote:
> Useful when debugging pxeboot, to see what the guest tries to do.

Good idea!

> 
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> ---
>   Makefile.objs      | 1 +
>   slirp/tftp.c       | 3 +++
>   slirp/trace-events | 5 +++++
>   3 files changed, 9 insertions(+)
>   create mode 100644 slirp/trace-events
> 
> diff --git a/Makefile.objs b/Makefile.objs
> index 1e1ff387d7..31852eaf8f 100644
> --- a/Makefile.objs
> +++ b/Makefile.objs
> @@ -251,6 +251,7 @@ trace-events-subdirs += net
>   trace-events-subdirs += qapi
>   trace-events-subdirs += qom
>   trace-events-subdirs += scsi
> +trace-events-subdirs += slirp
>   trace-events-subdirs += target/arm
>   trace-events-subdirs += target/i386
>   trace-events-subdirs += target/mips
> diff --git a/slirp/tftp.c b/slirp/tftp.c
> index a9bc4bb1b6..735b57aa55 100644
> --- a/slirp/tftp.c
> +++ b/slirp/tftp.c
> @@ -26,6 +26,7 @@
>   #include "slirp.h"
>   #include "qemu-common.h"
>   #include "qemu/cutils.h"
> +#include "trace.h"
>   
>   static inline int tftp_session_in_use(struct tftp_session *spt)
>   {
> @@ -204,6 +205,7 @@ static void tftp_send_error(struct tftp_session *spt,
>     struct mbuf *m;
>     struct tftp_t *tp;
>   
> +  trace_slirp_tftp_error(msg);
>     m = m_get(spt->slirp);
>   
>     if (!m) {
> @@ -323,6 +325,7 @@ static void tftp_handle_rrq(Slirp *slirp, struct sockaddr_storage *srcsas,
>         break;
>       }
>     }
> +  trace_slirp_tftp_rrq(req_fname);
>   
>     /* check mode */
>     if ((pktlen - k) < 6) {
> diff --git a/slirp/trace-events b/slirp/trace-events
> new file mode 100644
> index 0000000000..ff8f656e8c
> --- /dev/null
> +++ b/slirp/trace-events
> @@ -0,0 +1,5 @@
> +# See docs/devel/tracing.txt for syntax documentation.
> +
> +# slirp/tftp.c
> +slirp_tftp_rrq(const char *file) "file: %s"
> +slirp_tftp_error(const char *file) "msg: %s"
> 

  parent reply	other threads:[~2018-11-13 12:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-13  7:03 [Qemu-devel] [PATCH] slirp: add tftp tracing Gerd Hoffmann
2018-11-13  7:44 ` Liam Merwick
2018-11-13 12:38 ` Philippe Mathieu-Daudé [this message]
2018-11-14  0:42 ` Samuel Thibault

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bea636d4-9f0c-de1f-ac70-3ce4a2245033@redhat.com \
    --to=philmd@redhat.com \
    --cc=jan.kiszka@siemens.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=samuel.thibault@ens-lyon.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).