From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7272C388F9 for ; Fri, 23 Oct 2020 19:14:18 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D208120E65 for ; Fri, 23 Oct 2020 19:14:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="dDaBlkF+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D208120E65 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:45002 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kW2W0-0003Jw-Ki for qemu-devel@archiver.kernel.org; Fri, 23 Oct 2020 15:14:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57780) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kW2VR-0002rm-E9 for qemu-devel@nongnu.org; Fri, 23 Oct 2020 15:13:41 -0400 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]:37330) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kW2VP-00068N-75 for qemu-devel@nongnu.org; Fri, 23 Oct 2020 15:13:41 -0400 Received: by mail-pf1-x443.google.com with SMTP id 126so1701572pfu.4 for ; Fri, 23 Oct 2020 12:13:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=w5+o7Fuw8mcegapYPtHZXN+EuScY7pbJOQkVwlCvtJs=; b=dDaBlkF+/AUn3FhKuL7sO5xhz2m86yVz52EqhxTwn0pFkv6jCoY01bAwruk4Zmm/qx SpMJwP/Rrlae0k81B3RX50KtoEAdUYRXAydgCpP6zdr8gMm5m/1ICI/ECFgyG/5FpH9L se/DMKxVFJ2W409wN+QK28acqhGf2bWdN3LFztFQEzY1nfsX+X0Oii+l1Z4kyCEz0n9Z EkVU8trMhC4cCoV3vFfjhPwIq1MWq95fu38udVOTCVd5QqLs5Fsy2+frcPyxr5T7hNui Xb4JXpu8fDT+aY4JecASTGMD9ptYl1tIxW2vg7hfegZr9fE53G+46or7CDyw+0sgSV7b uO6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=w5+o7Fuw8mcegapYPtHZXN+EuScY7pbJOQkVwlCvtJs=; b=iuzuXV3dZu00IXj7tEp5wE23yRr2uCe8YGEtcPDIpLlbTWzliAPziqsegih2NMlqy6 slOYBG0az9+tBOwIL4CfUvuQt6bwIkov4kKknmAcc0wHoibbijsfuLyPyoJFHAChkysl PUzQDKywDr/eujb6NU+nhywsqKc3AVxEnAWiaVX4d3UEi9IV1aPDr6sc8w88pXVKOhk4 OC+hhCDF2U+7u+JCnIUgiEi2251A+CPk/zm7wSmocURH5NyxbJ7wbtfJUT9pwpjJZ81U tW1ZOme6t++rTuzIzyIpJZuT9jNPVmdAuXZJdyaQkgu0jg+fDcYSv/+hk0MO/7wPMreT /Asg== X-Gm-Message-State: AOAM530woue+JVDeDfD9oazMlVKisF+vR0sGTllOnZVy9hif/tc18cJ2 a2Nf+XXi2pgmcJYy6BAdP04bag== X-Google-Smtp-Source: ABdhPJymzrAfSMf6sMXC7gPsBC8wRCCAOljLD3/aS3le+kOLrlA6LJkBj5tO025gwIBQo1ODKV2STQ== X-Received: by 2002:a17:90a:17ad:: with SMTP id q42mr4417559pja.36.1603480417598; Fri, 23 Oct 2020 12:13:37 -0700 (PDT) Received: from [192.168.1.11] ([71.212.141.89]) by smtp.gmail.com with ESMTPSA id s141sm3009701pfs.75.2020.10.23.12.13.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Oct 2020 12:13:36 -0700 (PDT) Subject: Re: [PATCH v1 1/5] target/riscv: Add a virtualised MMU Mode To: Alistair Francis , qemu-devel@nongnu.org, qemu-riscv@nongnu.org References: <16213739a6232aa4824c5a008e2f669e6e58fbcf.1603466725.git.alistair.francis@wdc.com> From: Richard Henderson Message-ID: Date: Fri, 23 Oct 2020 12:13:34 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <16213739a6232aa4824c5a008e2f669e6e58fbcf.1603466725.git.alistair.francis@wdc.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::443; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x443.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.108, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alistair23@gmail.com, bmeng.cn@gmail.com, palmer@dabbelt.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 10/23/20 8:26 AM, Alistair Francis wrote: > +++ b/target/riscv/cpu-param.h > @@ -18,6 +18,6 @@ > # define TARGET_VIRT_ADDR_SPACE_BITS 32 /* sv32 */ > #endif > #define TARGET_PAGE_BITS 12 /* 4 KiB Pages */ > -#define NB_MMU_MODES 4 > +#define NB_MMU_MODES 8 Is there really a PRV_M + virt enabled state? > +#define TB_FLAGS_PRIV_MMU_MASK 3 ... > - int mode = mmu_idx; > + int mode = mmu_idx & 0x3; Use that MASK here? r~