qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Thomas Huth <thuth@redhat.com>, qemu-devel@nongnu.org
Cc: "Laurent Vivier" <lvivier@redhat.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Daniel P . Berrangé" <berrange@redhat.com>
Subject: Re: [PATCH] gitlab-ci: Use artifacts instead of dumping logs in the Cirrus-CI jobs
Date: Wed, 15 Feb 2023 16:55:42 +0100	[thread overview]
Message-ID: <beebbbb8-d83f-7c89-6adc-21ecc33ced82@linaro.org> (raw)
In-Reply-To: <4ba57bbf-3712-8958-e7c6-b164854e35ce@redhat.com>

On 15/2/23 16:45, Thomas Huth wrote:
> On 15/02/2023 15.57, Philippe Mathieu-Daudé wrote:
>> Hi Thomas,
>>
>> On 15/2/23 15:25, Thomas Huth wrote:
>>> The meson log files can get very big, especially if running the tests in
>>> verbose mode. So dumping those logs to the console was a bad idea, since
>>> gitlab truncates the output if it is getting too big. Let's publish the
>>> logs as artifacts instead. This has the disadvantage that you have to
>>> look up the logs on cirrus-ci.com now instead, but that's still better
>>> than not having the important part of the log at all since it got
>>> truncated.
>>>
>>> Fixes: 998f334722 ("gitlab: show testlog.txt contents ...")
>>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>>> ---
>>>   Note: I also tried to publish the junit xml files as artifacts
>>>   instead, but while the cirrus-ci docs claim to support it, I only
>>>   got unreadable XML output in my browser that way, so the .txt
>>>   files look like the better option to me.
>>>
>>>   .gitlab-ci.d/cirrus/build.yml | 7 +++++--
>>>   1 file changed, 5 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/.gitlab-ci.d/cirrus/build.yml 
>>> b/.gitlab-ci.d/cirrus/build.yml
>>> index 7ef6af8d33..a9444902ec 100644
>>> --- a/.gitlab-ci.d/cirrus/build.yml
>>> +++ b/.gitlab-ci.d/cirrus/build.yml
>>> @@ -32,6 +32,9 @@ build_task:
>>>       - $MAKE -j$(sysctl -n hw.ncpu)
>>>       - for TARGET in $TEST_TARGETS ;
>>>         do
>>> -        $MAKE -j$(sysctl -n hw.ncpu) $TARGET V=1
>>> -        || { cat meson-logs/testlog.txt; exit 1; } ;
>>> +        $MAKE -j$(sysctl -n hw.ncpu) $TARGET V=1 ;
>>>         done
>>> +  always:
>>> +    build_result_artifacts:
>>> +      path: build/meson-logs/*log.txt
>>> +      type: text/plain
>>
>> How long is that log kept available?
> 
> No clue, I haven't seen anything related in the docs:
> 
>   https://cirrus-ci.org/guide/writing-tasks/#artifacts-instruction
> 
> ... but I assume they will at least be available for a couple of days so 
> you've got enough time to look at them in case a job failed.

OK thanks.



  reply	other threads:[~2023-02-15 15:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-15 14:25 [PATCH] gitlab-ci: Use artifacts instead of dumping logs in the Cirrus-CI jobs Thomas Huth
2023-02-15 14:57 ` Philippe Mathieu-Daudé
2023-02-15 15:45   ` Thomas Huth
2023-02-15 15:55     ` Philippe Mathieu-Daudé [this message]
2023-02-15 14:58 ` Daniel P. Berrangé
2023-02-15 15:33   ` Thomas Huth
2023-02-15 15:37     ` Daniel P. Berrangé
2023-02-15 16:21     ` Peter Maydell
2023-02-16 17:15 ` Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=beebbbb8-d83f-7c89-6adc-21ecc33ced82@linaro.org \
    --to=philmd@linaro.org \
    --cc=alex.bennee@linaro.org \
    --cc=berrange@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).