From: Eric Blake <eblake@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org,
pbonzini@redhat.com, armbru@redhat.com, xiezhide@huawei.com
Subject: Re: [Qemu-devel] [PATCH v2] qapi: Reduce Makefile boilerplate
Date: Fri, 16 Nov 2018 09:06:32 -0600 [thread overview]
Message-ID: <bef6b1f7-327a-a786-a9c2-d69386eb98d8@redhat.com> (raw)
In-Reply-To: <20181116102659.GA28597@redhat.com>
On 11/16/18 4:26 AM, Daniel P. Berrangé wrote:
>> Makefile | 192 ++++++--------------------------------------------
>> Makefile.objs | 75 ++------------------
>> 2 files changed, 30 insertions(+), 237 deletions(-)
>
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
>
> Though I'd also suggest .gitignore is updated to use wildcards
> to exclude the generated files.
Oh, good idea. v3 coming up
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
prev parent reply other threads:[~2018-11-16 15:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 22:50 [Qemu-devel] [PATCH v2] qapi: Reduce Makefile boilerplate Eric Blake
2018-11-15 22:59 ` Paolo Bonzini
2018-11-16 10:17 ` Markus Armbruster
2018-11-16 10:26 ` Daniel P. Berrangé
2018-11-16 15:06 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bef6b1f7-327a-a786-a9c2-d69386eb98d8@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=xiezhide@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).