From: David Hildenbrand <david@redhat.com>
To: Ilya Leoshkevich <iii@linux.ibm.com>,
Laurent Vivier <laurent@vivier.eu>,
Richard Henderson <richard.henderson@linaro.org>
Cc: Thomas Huth <thuth@redhat.com>,
qemu-devel@nongnu.org, qemu-s390x@nongnu.org,
qemu-stable@nongnu.org
Subject: Re: [PATCH 06/12] target/s390x: Fix LRA when DAT is off
Date: Tue, 4 Jul 2023 09:53:39 +0200 [thread overview]
Message-ID: <bf01dde1-e08a-2cdb-8489-b7814f419c0c@redhat.com> (raw)
In-Reply-To: <20230703155801.179167-7-iii@linux.ibm.com>
On 03.07.23 17:50, Ilya Leoshkevich wrote:
> LRA should perform DAT regardless of whether it's on or off.
> Disable DAT check for MMU_S390_LRA.
>
> Fixes: defb0e3157af ("s390x: Implement opcode helpers")
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
> ---
> target/s390x/mmu_helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/s390x/mmu_helper.c b/target/s390x/mmu_helper.c
> index b04b57c2356..fbb2f1b4d48 100644
> --- a/target/s390x/mmu_helper.c
> +++ b/target/s390x/mmu_helper.c
> @@ -417,7 +417,7 @@ int mmu_translate(CPUS390XState *env, target_ulong vaddr, int rw, uint64_t asc,
>
> vaddr &= TARGET_PAGE_MASK;
>
> - if (!(env->psw.mask & PSW_MASK_DAT)) {
> + if (rw != MMU_S390_LRA && !(env->psw.mask & PSW_MASK_DAT)) {
> *raddr = vaddr;
> goto nodat;
> }
Interesting
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2023-07-04 7:54 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-03 15:50 [PATCH 00/12] target/s390x: Miscellaneous TCG fixes Ilya Leoshkevich
2023-07-03 15:50 ` [PATCH 01/12] linux-user: elfload: Add more initial s390x PSW bits Ilya Leoshkevich
2023-07-04 7:32 ` David Hildenbrand
2023-07-04 7:40 ` Ilya Leoshkevich
2023-07-04 7:48 ` David Hildenbrand
2023-07-03 15:50 ` [PATCH 02/12] target/s390x: Fix EPSW CC reporting Ilya Leoshkevich
2023-07-04 7:38 ` David Hildenbrand
2023-07-03 15:50 ` [PATCH 03/12] target/s390x: Fix MDEB and MDEBR Ilya Leoshkevich
2023-07-04 7:40 ` David Hildenbrand
2023-07-03 15:50 ` [PATCH 04/12] target/s390x: Fix MVCRL with a large value in R0 Ilya Leoshkevich
2023-07-04 7:40 ` David Hildenbrand
2023-07-03 15:50 ` [PATCH 05/12] target/s390x: Fix LRA overwriting the top 32 bits on DAT error Ilya Leoshkevich
2023-07-04 7:47 ` David Hildenbrand
2023-07-04 8:05 ` Ilya Leoshkevich
2023-07-04 8:06 ` Richard Henderson
2023-07-04 8:14 ` David Hildenbrand
2023-07-03 15:50 ` [PATCH 06/12] target/s390x: Fix LRA when DAT is off Ilya Leoshkevich
2023-07-04 7:53 ` David Hildenbrand [this message]
2023-07-03 15:50 ` [PATCH 07/12] target/s390x: Fix relative long instructions with large offsets Ilya Leoshkevich
2023-07-04 7:54 ` David Hildenbrand
2023-07-03 15:50 ` [PATCH 08/12] tests/tcg/s390x: Test EPSW Ilya Leoshkevich
2023-07-04 7:55 ` David Hildenbrand
2023-07-03 15:50 ` [PATCH 09/12] tests/tcg/s390x: Test LARL with a large offset Ilya Leoshkevich
2023-07-04 7:56 ` David Hildenbrand
2023-07-04 7:59 ` Ilya Leoshkevich
2023-07-03 15:50 ` [PATCH 10/12] tests/tcg/s390x: Test LRA Ilya Leoshkevich
2023-07-03 15:50 ` [PATCH 11/12] tests/tcg/s390x: Test MDEB and MDEBR Ilya Leoshkevich
2023-07-04 7:58 ` David Hildenbrand
2023-07-03 15:50 ` [PATCH 12/12] tests/tcg/s390x: Test MVCRL with a large value in R0 Ilya Leoshkevich
2023-07-04 7:59 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf01dde1-e08a-2cdb-8489-b7814f419c0c@redhat.com \
--to=david@redhat.com \
--cc=iii@linux.ibm.com \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).