qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>,
	Martin Kaiser <martin@kaiser.cx>
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	qemu-arm@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH v3] imx_serial: set wake bit when we receive a data byte
Date: Mon, 19 Jun 2023 15:09:44 +0200	[thread overview]
Message-ID: <bf02a3c4-7961-00a3-db42-031d0ecd1942@linaro.org> (raw)
In-Reply-To: <CAFEAcA84ng=jMTvb+XHrvGatf7UOPNxg7u+m-LXKVYT_kaDm5g@mail.gmail.com>

On 19/6/23 12:36, Peter Maydell wrote:
> On Thu, 15 Jun 2023 at 15:24, Martin Kaiser <martin@kaiser.cx> wrote:
>>
>> The Linux kernel added a flood check for RX data recently in commit
>> 496a4471b7c3 ("serial: imx: work-around for hardware RX flood"). This
>> check uses the wake bit in the UART status register 2. The wake bit
>> indicates that the receiver detected a start bit on the RX line. If the
>> kernel sees a number of RX interrupts without the wake bit being set, it
>> treats this as spurious data and resets the UART port. imx_serial does
>> never set the wake bit and triggers the kernel's flood check.
>>
>> This patch adds support for the wake bit. wake is set when we receive a
>> new character (it's not set for break events). It seems that wake is
>> cleared by the kernel driver, the hardware does not have to clear it
>> automatically after data was read.
>>
>> The wake bit can be configured as an interrupt source. Support this
>> mechanism as well.
>>
>> Co-developed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>

>> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> 
> 
> 
> Applied to target-arm.next, thanks.
> 
> -- PMM



      reply	other threads:[~2023-06-19 13:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-08 15:41 [PATCH] imx_serial: set wake bit when we receive a data byte Martin Kaiser
2023-06-12 13:23 ` Philippe Mathieu-Daudé
2023-06-15  9:27   ` Martin Kaiser
2023-06-15  9:30 ` [PATCH v2] " Martin Kaiser
2023-06-15 10:25   ` Philippe Mathieu-Daudé
2023-06-15 14:22 ` [PATCH v3] " Martin Kaiser
2023-06-19 10:36   ` Peter Maydell
2023-06-19 13:09     ` Philippe Mathieu-Daudé [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bf02a3c4-7961-00a3-db42-031d0ecd1942@linaro.org \
    --to=philmd@linaro.org \
    --cc=marcandre.lureau@redhat.com \
    --cc=martin@kaiser.cx \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).