[PATCH] hw/misc/macio: Improve trace logs

[PATCH] hw/misc/macio: Improve trace logs

[BALATON Zoltan]

Add macio_gpio_read trace event and use that in macio_gpio_read()
instead of macio_gpio_write. Also change log message to match
macio_timer_{read,write}.

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
---
 hw/misc/macio/gpio.c       | 2 +-
 hw/misc/macio/trace-events | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/hw/misc/macio/gpio.c b/hw/misc/macio/gpio.c
index 7cad62819a..4364afc84a 100644
--- a/hw/misc/macio/gpio.c
+++ b/hw/misc/macio/gpio.c
@@ -135,7 +135,7 @@ static uint64_t macio_gpio_read(void *opaque, hwaddr addr, unsigned size)
         }
     }
 
-    trace_macio_gpio_write(addr, val);
+    trace_macio_gpio_read(addr, val);
     return val;
 }
 
diff --git a/hw/misc/macio/trace-events b/hw/misc/macio/trace-events
index ad4b9d1c08..055a407aeb 100644
--- a/hw/misc/macio/trace-events
+++ b/hw/misc/macio/trace-events
@@ -18,7 +18,8 @@ macio_timer_read(uint64_t addr, unsigned len, uint32_t val) "read addr 0x%"PRIx6
 macio_set_gpio(int gpio, bool state) "setting GPIO %d to %d"
 macio_gpio_irq_assert(int gpio) "asserting GPIO %d"
 macio_gpio_irq_deassert(int gpio) "deasserting GPIO %d"
-macio_gpio_write(uint64_t addr, uint64_t val) "addr: 0x%"PRIx64" value: 0x%"PRIx64
+macio_gpio_write(uint64_t addr, uint64_t val) "addr 0x%"PRIx64" val 0x%"PRIx64
+macio_gpio_read(uint64_t addr, uint64_t val) "addr 0x%"PRIx64" val 0x%"PRIx64
 
 # pmu.c
 pmu_adb_poll(int olen) "ADB autopoll, olen=%d"
-- 
2.30.9

Re: [PATCH] hw/misc/macio: Improve trace logs

[Philippe Mathieu-Daudé]

On 22/2/25 13:28, BALATON Zoltan wrote:
> Add macio_gpio_read trace event and use that in macio_gpio_read()
> instead of macio_gpio_write. Also change log message to match
> macio_timer_{read,write}.
> 
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
>   hw/misc/macio/gpio.c       | 2 +-
>   hw/misc/macio/trace-events | 3 ++-
>   2 files changed, 3 insertions(+), 2 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Re: [PATCH] hw/misc/macio: Improve trace logs

[Mark Cave-Ayland]

On 22/02/2025 12:28, BALATON Zoltan wrote:

> Add macio_gpio_read trace event and use that in macio_gpio_read()
> instead of macio_gpio_write. Also change log message to match
> macio_timer_{read,write}.
> 
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
>   hw/misc/macio/gpio.c       | 2 +-
>   hw/misc/macio/trace-events | 3 ++-
>   2 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/misc/macio/gpio.c b/hw/misc/macio/gpio.c
> index 7cad62819a..4364afc84a 100644
> --- a/hw/misc/macio/gpio.c
> +++ b/hw/misc/macio/gpio.c
> @@ -135,7 +135,7 @@ static uint64_t macio_gpio_read(void *opaque, hwaddr addr, unsigned size)
>           }
>       }
>   
> -    trace_macio_gpio_write(addr, val);
> +    trace_macio_gpio_read(addr, val);
>       return val;
>   }
>   
> diff --git a/hw/misc/macio/trace-events b/hw/misc/macio/trace-events
> index ad4b9d1c08..055a407aeb 100644
> --- a/hw/misc/macio/trace-events
> +++ b/hw/misc/macio/trace-events
> @@ -18,7 +18,8 @@ macio_timer_read(uint64_t addr, unsigned len, uint32_t val) "read addr 0x%"PRIx6
>   macio_set_gpio(int gpio, bool state) "setting GPIO %d to %d"
>   macio_gpio_irq_assert(int gpio) "asserting GPIO %d"
>   macio_gpio_irq_deassert(int gpio) "deasserting GPIO %d"
> -macio_gpio_write(uint64_t addr, uint64_t val) "addr: 0x%"PRIx64" value: 0x%"PRIx64
> +macio_gpio_write(uint64_t addr, uint64_t val) "addr 0x%"PRIx64" val 0x%"PRIx64
> +macio_gpio_read(uint64_t addr, uint64_t val) "addr 0x%"PRIx64" val 0x%"PRIx64
>   
>   # pmu.c
>   pmu_adb_poll(int olen) "ADB autopoll, olen=%d"

Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>


ATB,

Mark.

Re: [PATCH] hw/misc/macio: Improve trace logs

[Philippe Mathieu-Daudé]

On 22/2/25 13:28, BALATON Zoltan wrote:
> Add macio_gpio_read trace event and use that in macio_gpio_read()
> instead of macio_gpio_write. Also change log message to match
> macio_timer_{read,write}.
> 
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
>   hw/misc/macio/gpio.c       | 2 +-
>   hw/misc/macio/trace-events | 3 ++-
>   2 files changed, 3 insertions(+), 2 deletions(-)

Patch queued.