qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Laszlo Ersek <lersek@redhat.com>,
	Richard Henderson <richard.henderson@linaro.org>,
	Gerd Hoffmann <kraxel@redhat.com>,
	qemu-block@nongnu.org
Subject: Re: [PATCH v3 1/1] hw/nvram: Always register FW_CFG_DATA_GENERATOR_INTERFACE
Date: Tue, 6 Oct 2020 18:20:06 +0200	[thread overview]
Message-ID: <bf40cc1e-bdea-1507-f4f1-a0822ceea6d6@redhat.com> (raw)
In-Reply-To: <a73ef334-01c2-21f8-e793-15e822da28a0@redhat.com>

On 10/6/20 6:15 PM, Paolo Bonzini wrote:
> On 06/10/20 18:02, Philippe Mathieu-Daudé wrote:
>> On 10/6/20 5:51 PM, Richard Henderson wrote:
>>> On 10/6/20 10:36 AM, Philippe Mathieu-Daudé wrote:
>>>> +++ b/hw/nvram/fw_cfg-interface.c
>>>> @@ -0,0 +1,15 @@
>>>> +#include "qemu/osdep.h"
>>>> +#include "hw/nvram/fw_cfg.h"
>>>
>>> License boilerplate missing.
>>
>> Grr. Paolo since you queued this, do you mind fixing directly?
>>
> 
> Please write it here and I'll paste it in place.

/*
 * QEMU Firmware configuration device emulation (QOM interfaces)
 *
 * Copyright 2020 Red Hat, Inc.
 *
 * SPDX-License-Identifier: GPL-2.0-or-later
 */

Thanks!

Phil.



  reply	other threads:[~2020-10-06 16:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-06 15:36 [PATCH v3 0/1] qom: Fix missing interface in qemu-storage-daemon Philippe Mathieu-Daudé
2020-10-06 15:36 ` [PATCH v3 1/1] hw/nvram: Always register FW_CFG_DATA_GENERATOR_INTERFACE Philippe Mathieu-Daudé
2020-10-06 15:42   ` Paolo Bonzini
2020-10-06 15:51   ` Richard Henderson
2020-10-06 16:02     ` Philippe Mathieu-Daudé
2020-10-06 16:15       ` Paolo Bonzini
2020-10-06 16:20         ` Philippe Mathieu-Daudé [this message]
2020-10-06 16:04     ` Laszlo Ersek
2020-10-06 16:08       ` Philippe Mathieu-Daudé
2020-10-06 16:16         ` Laszlo Ersek
2020-10-06 15:54 ` [PATCH v3 0/1] qom: Fix missing interface in qemu-storage-daemon no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bf40cc1e-bdea-1507-f4f1-a0822ceea6d6@redhat.com \
    --to=philmd@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=lersek@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).