From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43110) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c59zA-0007HK-Ma for qemu-devel@nongnu.org; Fri, 11 Nov 2016 06:27:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c59z7-00017O-MC for qemu-devel@nongnu.org; Fri, 11 Nov 2016 06:27:08 -0500 Received: from mx1.redhat.com ([209.132.183.28]:56622) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c59z7-000174-G7 for qemu-devel@nongnu.org; Fri, 11 Nov 2016 06:27:05 -0500 References: <3d8be595c30d0009464ce16e90ee8fb5451e5605.1478619442.git.vpalatin@chromium.org> <4392fa15-865d-2424-88a6-c422d62a4fb1@redhat.com> From: Paolo Bonzini Message-ID: Date: Fri, 11 Nov 2016 12:26:59 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/3] Plumb the HAXM-based hardware acceleration support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vincent Palatin Cc: qemu-devel On 11/11/2016 12:25, Vincent Palatin wrote: > On Wed, Nov 9, 2016 at 6:32 PM, Paolo Bonzini wrote: >> >> >> On 09/11/2016 18:19, Vincent Palatin wrote: >>>>> Please try removing this block and instead starting QEMU with >>>>> -mem-prealloc. If it works, remove hax_populate_ram and just set >>>>> mem_prealloc to 1 in hax_accel_init. >>> it's not working, later hax_set_ram() is unhappy about what it is >>> finding the mappings. >>> By the way, even if it had worked at startup, under memory pressure, >>> Windows might have evicted the physical pages (which is not supported >>> by the HAXM kernel module) >>> >>> I can try to move this in os_mem_prealloc() if you feel it's cleaner. >> >> Yes, that would work! > > Actually, os_mem_prealloc seems mostly no-op in the win32 version, > I have postponed this change for after my v2 patchset. Good, we'll sort it out during review. Paolo