From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Bernhard Beschow <shentey@gmail.com>, qemu-devel@nongnu.org
Cc: "Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Hervé Poussineau" <hpoussin@reactos.org>,
"Artyom Tarasenko" <atar4qemu@gmail.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Huacai Chen" <chenhuacai@kernel.org>,
qemu-ppc@nongnu.org,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
"Jiaxun Yang" <jiaxun.yang@flygoat.com>
Subject: Re: [PATCH 3/4] hw/pci-host/bonito: Access memory regions via pci_address_space[_io]()
Date: Mon, 16 Oct 2023 09:04:17 +0200 [thread overview]
Message-ID: <bf5d344c-84a1-c6b9-3d17-0362a4c2c9e7@linaro.org> (raw)
In-Reply-To: <5FD62714-3C33-4A93-B7E3-F3523FCE69C1@gmail.com>
On 16/10/23 00:19, Bernhard Beschow wrote:
> Am 11. Oktober 2023 18:59:53 UTC schrieb "Philippe Mathieu-Daudé" <philmd@linaro.org>:
>> PCI functions are plugged on a PCI bus. They can only access
>> external memory regions via the bus.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>> ---
>> hw/pci-host/bonito.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>> @@ -719,7 +719,7 @@ static void bonito_pci_realize(PCIDevice *dev, Error **errp)
>>
>> memory_region_init_alias(pcimem_alias, NULL, "pci.mem.alias",
>> &bs->pci_mem, 0, BONITO_PCIHI_SIZE);
>> - memory_region_add_subregion(get_system_memory(),
>> + memory_region_add_subregion(pci_address_space(dev),
>
> I need to keep `get_system_memory()` here to get the same results for `info mtree` in the QEMU console before and after this patch when running `qemu-system-mips64el -M fuloong2e -S`. The other two changes above seem to work as expected.
Good catch, thank you Bernhard!
next prev parent reply other threads:[~2023-10-16 7:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-11 18:59 [PATCH 0/4] hw/pci: Have functions acess memory regions via pci_address_space() Philippe Mathieu-Daudé
2023-10-11 18:59 ` [PATCH 1/4] hw/isa/i82378: Access " Philippe Mathieu-Daudé
2023-10-15 22:13 ` Bernhard Beschow
2023-10-11 18:59 ` [PATCH 2/4] hw/isa/lpc_ich9: Access memory regions via pci_address_space[_io]() Philippe Mathieu-Daudé
2023-10-16 10:27 ` Bernhard Beschow
2023-10-11 18:59 ` [PATCH 3/4] hw/pci-host/bonito: " Philippe Mathieu-Daudé
2023-10-15 22:19 ` Bernhard Beschow
2023-10-16 7:04 ` Philippe Mathieu-Daudé [this message]
2024-02-06 15:45 ` Philippe Mathieu-Daudé
2024-02-06 16:14 ` Bernhard Beschow
2023-10-11 18:59 ` [PATCH 4/4] hw/sparc64/ebus: Access memory regions via pci_address_space_io() Philippe Mathieu-Daudé
2023-10-13 18:29 ` Mark Cave-Ayland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf5d344c-84a1-c6b9-3d17-0362a4c2c9e7@linaro.org \
--to=philmd@linaro.org \
--cc=atar4qemu@gmail.com \
--cc=chenhuacai@kernel.org \
--cc=hpoussin@reactos.org \
--cc=jiaxun.yang@flygoat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=shentey@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).