From: John Snow <jsnow@redhat.com>
To: "Stefan Hajnoczi" <stefanha@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: Elena Ufimtseva <elena.ufimtseva@oracle.com>,
John G Johnson <john.g.johnson@oracle.com>,
Thomas Huth <thuth@redhat.com>,
Jagannathan Raman <jag.raman@oracle.com>,
qemu-block@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH] hw/ide: Fix crash when plugging a piix3-ide device into the x-remote machine
Date: Tue, 27 Apr 2021 13:16:33 -0400 [thread overview]
Message-ID: <bf5d8b58-3364-3f61-0c89-53f16c64bcb3@redhat.com> (raw)
In-Reply-To: <YIgXlp9Auj+b00aN@stefanha-x1.localdomain>
On 4/27/21 9:54 AM, Stefan Hajnoczi wrote:
> I suggest fixing this at the qdev level. Make piix3-ide have a
> sub-device that inherits from ISA_DEVICE so it can only be instantiated
> when there's an ISA bus.
>
> Stefan
My qdev knowledge is shaky. Does this imply that you agree with the
direction of Thomas's patch, or do you just mean to disagree with Phil
on his preferred course of action?
--js
next prev parent reply other threads:[~2021-04-27 17:18 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-16 12:52 [PATCH] hw/ide: Fix crash when plugging a piix3-ide device into the x-remote machine Thomas Huth
2021-04-27 13:27 ` Philippe Mathieu-Daudé
2021-04-27 13:54 ` Stefan Hajnoczi
2021-04-27 17:16 ` John Snow [this message]
2021-04-27 17:54 ` Philippe Mathieu-Daudé
2021-04-27 18:02 ` John Snow
2021-04-28 9:22 ` Stefan Hajnoczi
2021-04-28 14:18 ` Markus Armbruster
2021-04-28 18:43 ` Stefan Hajnoczi
2021-04-29 6:08 ` Markus Armbruster
2021-05-03 17:53 ` Philippe Mathieu-Daudé
2021-04-28 9:15 ` Stefan Hajnoczi
2021-04-28 14:21 ` Markus Armbruster
2021-04-27 18:06 ` John Snow
2021-04-28 9:24 ` Stefan Hajnoczi
2021-04-28 9:32 ` Thomas Huth
2021-04-28 10:53 ` Philippe Mathieu-Daudé
2021-05-18 19:21 ` John Snow
2021-05-18 21:07 ` John Snow
2021-07-06 8:24 ` Thomas Huth
2021-07-06 8:37 ` Philippe Mathieu-Daudé
2021-07-07 9:30 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf5d8b58-3364-3f61-0c89-53f16c64bcb3@redhat.com \
--to=jsnow@redhat.com \
--cc=elena.ufimtseva@oracle.com \
--cc=jag.raman@oracle.com \
--cc=john.g.johnson@oracle.com \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).