From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Thomas Huth <thuth@redhat.com>,
qemu-s390x@nongnu.org,
Richard Henderson <richard.henderson@linaro.org>,
David Hildenbrand <david@redhat.com>,
Ilya Leoshkevich <iii@linux.ibm.com>,
Cornelia Huck <cohuck@redhat.com>,
Halil Pasic <pasic@linux.ibm.com>,
Eric Farman <farman@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>
Subject: Re: [PATCH for-9.2 06/10] hw/remote/message.c: Don't directly invoke DeviceClass:reset
Date: Wed, 14 Aug 2024 15:48:52 +0200 [thread overview]
Message-ID: <bf66bee5-1a52-4add-a6f5-56cb03c3a24f@linaro.org> (raw)
In-Reply-To: <20240813165250.2717650-7-peter.maydell@linaro.org>
On 13/8/24 18:52, Peter Maydell wrote:
> Directly invoking the DeviceClass::reset method is a bad idea,
> because if the device is using three-phase reset then it relies on
> transitional reset machinery which is likely to disappear at some
> point.
This seems like fix-for-9.1 material.
> Reset the device in the standard way, by calling device_cold_reset().
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> hw/remote/message.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2024-08-14 13:50 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-13 16:52 [PATCH for-9.2 00/10] s390: Convert virtio-ccw, cpu to three-phase reset, and followup cleanup Peter Maydell
2024-08-13 16:52 ` [PATCH for-9.2 01/10] hw/s390/virtio-ccw: Convert to three-phase reset Peter Maydell
2024-08-13 22:07 ` Richard Henderson
2024-08-14 10:43 ` Thomas Huth
2024-08-23 17:34 ` Nina Schoetterl-Glausch
2024-08-26 16:02 ` Philippe Mathieu-Daudé
2024-08-26 17:11 ` Peter Maydell
2024-08-13 16:52 ` [PATCH for-9.2 02/10] target/s390: Convert CPU to Resettable interface Peter Maydell
2024-08-13 23:03 ` Richard Henderson
2024-08-14 10:56 ` Thomas Huth
2024-08-23 17:44 ` Nina Schoetterl-Glausch
2024-08-23 20:32 ` Peter Maydell
2024-08-13 16:52 ` [PATCH for-9.2 03/10] hw: Remove device_class_set_parent_reset() Peter Maydell
2024-08-13 23:06 ` Richard Henderson
2024-08-26 16:03 ` Philippe Mathieu-Daudé
2024-08-13 16:52 ` [PATCH for-9.2 04/10] target/alpha, hppa: Remove unused parent_reset fields Peter Maydell
2024-08-13 23:08 ` Richard Henderson
2024-08-13 16:52 ` [PATCH for-9.2 05/10] hw/dma/xilinx_axidma: Use semicolon at end of statement, not comma Peter Maydell
2024-08-13 23:08 ` Richard Henderson
2024-08-14 10:55 ` Thomas Huth
2024-08-13 16:52 ` [PATCH for-9.2 06/10] hw/remote/message.c: Don't directly invoke DeviceClass:reset Peter Maydell
2024-08-13 23:10 ` Richard Henderson
2024-08-14 13:48 ` Philippe Mathieu-Daudé [this message]
2024-08-13 16:52 ` [PATCH for-9.2 07/10] hw: Define new device_class_set_legacy_reset() Peter Maydell
2024-08-13 23:12 ` Richard Henderson
2024-08-26 16:06 ` Philippe Mathieu-Daudé
2024-08-13 16:52 ` [PATCH for-9.2 08/10] hw: Use device_class_set_legacy_reset() instead of opencoding Peter Maydell
2024-08-13 23:14 ` Richard Henderson
2024-08-13 16:52 ` [PATCH for-9.2 09/10] hw: Rename DeviceClass::reset field to legacy_reset Peter Maydell
2024-08-13 23:15 ` Richard Henderson
2024-08-26 16:07 ` Philippe Mathieu-Daudé
2024-08-13 16:52 ` [PATCH for-9.2 10/10] hw: Remove device_phases_reset() Peter Maydell
2024-08-14 0:53 ` Richard Henderson
2024-08-14 13:20 ` Peter Maydell
2024-08-14 14:22 ` [PATCH for-9.2 00/10] s390: Convert virtio-ccw, cpu to three-phase reset, and followup cleanup Christian Borntraeger
2024-08-14 20:06 ` Peter Maydell
2024-08-22 10:34 ` Nina Schoetterl-Glausch
2024-08-26 12:08 ` Nico Boehr
2024-08-28 8:13 ` Nico Boehr
2024-08-28 15:46 ` Peter Maydell
2024-08-29 12:19 ` Nico Boehr
2024-08-29 13:09 ` Peter Maydell
2024-08-29 13:20 ` Cédric Le Goater
2024-08-29 13:26 ` Nico Boehr
2024-08-29 13:35 ` Peter Maydell
2024-08-29 14:44 ` Nico Boehr
2024-08-29 15:08 ` Peter Maydell
2024-08-29 15:53 ` Peter Maydell
2024-08-30 5:48 ` Nico Boehr
2024-08-30 10:01 ` Peter Maydell
2024-08-30 11:56 ` Nico Boehr
2024-08-30 12:04 ` Peter Maydell
2024-08-30 12:17 ` Peter Maydell
2024-08-30 12:21 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf66bee5-1a52-4add-a6f5-56cb03c3a24f@linaro.org \
--to=philmd@linaro.org \
--cc=borntraeger@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=farman@linux.ibm.com \
--cc=iii@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).