qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Ilya Leoshkevich <iii@linux.ibm.com>,
	Richard Henderson <richard.henderson@linaro.org>,
	Laurent Vivier <laurent@vivier.eu>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Peter Xu <peterx@redhat.com>,
	David Hildenbrand <david@redhat.com>,
	qemu-devel@nongnu.org
Subject: Re: [PATCH v2 4/4] accel/tcg: Move perf and debuginfo support to tcg
Date: Sat, 1 Jul 2023 01:53:44 +0200	[thread overview]
Message-ID: <bf6e3ba0-7625-9a12-b0a9-ee6bb1d1e247@linaro.org> (raw)
In-Reply-To: <20230630234230.596193-5-iii@linux.ibm.com>

On 1/7/23 01:40, Ilya Leoshkevich wrote:
> tcg/ should not depend on accel/tcg/, but perf and debuginfo
> support provided by the latter are being used by tcg/tcg.c.
> 
> Since that's the only user, move both to tcg/.
> 
> Suggested-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
> ---
>   accel/tcg/meson.build          | 2 --
>   accel/tcg/translate-all.c      | 2 +-
>   hw/core/loader.c               | 2 +-
>   linux-user/elfload.c           | 2 +-
>   linux-user/exit.c              | 2 +-
>   linux-user/main.c              | 2 +-
>   softmmu/vl.c                   | 2 +-
>   {accel/tcg => tcg}/debuginfo.c | 0
>   {accel/tcg => tcg}/debuginfo.h | 4 ++--
>   tcg/meson.build                | 3 +++
>   {accel/tcg => tcg}/perf.c      | 2 +-
>   {accel/tcg => tcg}/perf.h      | 4 ++--
>   tcg/tcg.c                      | 2 +-
>   13 files changed, 15 insertions(+), 14 deletions(-)
>   rename {accel/tcg => tcg}/debuginfo.c (100%)
>   rename {accel/tcg => tcg}/debuginfo.h (96%)
>   rename {accel/tcg => tcg}/perf.c (99%)
>   rename {accel/tcg => tcg}/perf.h (95%)

Easier that what I thought, thanks!

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>



      reply	other threads:[~2023-06-30 23:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-30 23:40 [PATCH v2 0/4] accel/tcg: Move perf and debuginfo support to tcg Ilya Leoshkevich
2023-06-30 23:40 ` [PATCH v2 1/4] target: Make qemu_target_page_mask() available for *-user Ilya Leoshkevich
2023-06-30 23:40 ` [PATCH v2 2/4] tcg: Make tb_cflags() usable from target-agnostic code Ilya Leoshkevich
2023-06-30 23:40 ` [PATCH v2 3/4] accel/tcg: Remove #ifdef TARGET_I386 from perf.c Ilya Leoshkevich
2023-06-30 23:40 ` [PATCH v2 4/4] accel/tcg: Move perf and debuginfo support to tcg Ilya Leoshkevich
2023-06-30 23:53   ` Philippe Mathieu-Daudé [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bf6e3ba0-7625-9a12-b0a9-ee6bb1d1e247@linaro.org \
    --to=philmd@linaro.org \
    --cc=david@redhat.com \
    --cc=iii@linux.ibm.com \
    --cc=laurent@vivier.eu \
    --cc=pbonzini@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).